From owner-cvs-all Mon Jun 17 17:27:32 2002 Delivered-To: cvs-all@freebsd.org Received: from gateway.posi.net (12-236-90-177.client.attbi.com [12.236.90.177]) by hub.freebsd.org (Postfix) with ESMTP id AA74537B426; Mon, 17 Jun 2002 17:27:10 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by gateway.posi.net (8.12.3/8.12.3) with ESMTP id g5I0R9M7075328; Mon, 17 Jun 2002 17:27:09 -0700 (PDT) (envelope-from kbyanc@posi.net) Date: Mon, 17 Jun 2002 17:27:09 -0700 (PDT) From: Kelly Yancey To: Kelly Yancey Cc: cvs-committers@FreeBSD.org, Subject: Re: cvs commit: src/sys/netinet if_ether.c src/sys/net if_iso88025subr.c iso88025.h In-Reply-To: <200206180015.g5I0FV070856@freefall.freebsd.org> Message-ID: <20020617172132.R72633-100000@gateway.posi.net> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Mon, 17 Jun 2002, Kelly Yancey wrote: > kbyanc 2002/06/17 17:15:31 PDT > > Modified files: (Branch: RELENG_4) > sys/netinet if_ether.c > sys/net if_iso88025subr.c iso88025.h > Log: > MFC netinet/if_ether.c:1.93-1.94, > net/if_iso88025subr.c:1.21, > net/iso88025.h:1.6-1.8: > Move ISO88025 source routing information into sockaddr_dl's > sdl_data field. This returns the sdl_data field to a > variable-length field. More importantly, this prevents a > easily-reproduceable data-corruption bug when the interface name > plus the hardware address exceed the sdl_data field's original 12 > byte limit. However, token-ring interfaces may still overflow the > new sdl_data field's 46 byte limit if the interface name exceeds 6 > characters (since 6 characters for interface name plus 6 for hardware > address plus 34 for source routing = the size of sdl_data). > Maybe now I'll get some feedback for those individuals rumored to own token-ring equipment. Or perhaps almost 2 months of silence is a remarkably good sign that these changes didn't adversely affect them at all. I can hope, can't I? :) Kelly -- Kelly Yancey -- kbyanc@{posi.net,FreeBSD.org} Visit the BSD driver database: http://www.posi.net/freebsd/drivers/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message