From owner-freebsd-hackers Wed Feb 6 15:39:56 2002 Delivered-To: freebsd-hackers@freebsd.org Received: from birch.ripe.net (birch.ripe.net [193.0.1.96]) by hub.freebsd.org (Postfix) with ESMTP id 4C99637B41C for ; Wed, 6 Feb 2002 15:39:40 -0800 (PST) Received: from laptop.6bone.nl (penguin.ripe.net [193.0.1.232]) by birch.ripe.net (8.11.6/8.11.6) with SMTP id g16Nddh12269; Thu, 7 Feb 2002 00:39:39 +0100 Received: (nullmailer pid 97465 invoked by uid 1000); Wed, 06 Feb 2002 23:39:36 -0000 Date: Thu, 7 Feb 2002 00:39:36 +0100 From: Mark Santcroos To: hackers@freebsd.org Cc: Julian Elischer Subject: [PATCH] nmdm fixes Message-ID: <20020207003936.K16264@laptop.6bone.nl> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i X-Handles: MS6-6BONE, MS18417-RIPE Sender: owner-freebsd-hackers@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Using the nmdm driver for serial console debugging in vmware I was really surprised to notice that the thing actually doesn't work at all (anymore). As far as I could find out it only supported one pair. Also after a close, when I would do a "ls -al /dev/nmdm*", I would get a kernel panic. I rewrote nmdm.c to the basic point that it works fine for me. One can now create multiple pairs and I haven't got any panics or problems whatsoever. I also took the liberty to remove the ancient K&R requirements at the same time now there is a large code change anyway. Please review the patch at: http://www.ripe.net/home/mark/files/nmdm.diff I would appreciate any feedback ranging from: 'hey, you should do it like this!' to 'committed!'. I only used/tested this on -CURRENT btw. Thanks to Julian for writing the driver initially. Mark -- Mark Santcroos RIPE Network Coordination Centre http://www.ripe.net/home/mark/ New Projects Group/TTM To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message