From owner-cvs-all@FreeBSD.ORG Tue Sep 21 18:57:17 2010 Return-Path: Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 99C5D1065695 for ; Tue, 21 Sep 2010 18:57:17 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from mail2.fluidhosting.com (mx21.fluidhosting.com [204.14.89.4]) by mx1.freebsd.org (Postfix) with ESMTP id 26A148FC17 for ; Tue, 21 Sep 2010 18:57:16 +0000 (UTC) Received: (qmail 29598 invoked by uid 399); 21 Sep 2010 18:57:16 -0000 Received: from localhost (HELO ?192.168.0.142?) (dougb@dougbarton.us@127.0.0.1) by localhost with ESMTPAM; 21 Sep 2010 18:57:16 -0000 X-Originating-IP: 127.0.0.1 X-Sender: dougb@dougbarton.us Message-ID: <4C99000C.2080205@FreeBSD.org> Date: Tue, 21 Sep 2010 11:57:16 -0700 From: Doug Barton Organization: http://SupersetSolutions.com/ User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2.9) Gecko/20100915 Thunderbird/3.1.4 MIME-Version: 1.0 To: Renato Botelho References: <201009211539.o8LFdg7p016823@repoman.freebsd.org> In-Reply-To: <201009211539.o8LFdg7p016823@repoman.freebsd.org> X-Enigmail-Version: 1.2a1pre OpenPGP: id=1A1ABC84 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/www/monast Makefile pkg-plist ports/www/monast/files monast.in X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Sep 2010 18:57:17 -0000 On 9/21/2010 8:39 AM, Renato Botelho wrote: > garga 2010-09-21 15:39:42 UTC > > FreeBSD ports repository > > Modified files: > www/monast Makefile pkg-plist > Added files: > www/monast/files monast.in > Log: > - Remove unecessary patch and convert it to REINPLACE_CMD > - Respect PREFIX > - Use USE_RC_SUBR instead of install startup script manually Yay. :) Just one nit, you can't have REQUIRE and BEFORE with the same targets. I think the REQUIRE can just be removed in the script. You might also consider adding a $FreeBSD$. Otherwise looks great! > - Simplify mkdirs > > Revision Changes Path > 1.2 +8 -11 ports/www/monast/Makefile > 1.1 +27 -0 ports/www/monast/files/monast.in (new) > 1.2 +0 -1 ports/www/monast/pkg-plist > > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/www/monast/Makefile.diff?&r1=1.1&r2=1.2&f=h > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/www/monast/files/monast.in > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/www/monast/pkg-plist.diff?&r1=1.1&r2=1.2&f=h > -- ... and that's just a little bit of history repeating. -- Propellerheads Improve the effectiveness of your Internet presence with a domain name makeover! http://SupersetSolutions.com/