Date: Wed, 15 Aug 2018 17:00:13 +0200 From: Emmanuel Vadot <manu@bidouilliste.com> To: John-Mark Gurney <jmg@funkthat.com> Cc: uboot@FreeBSD.org Subject: Re: u-boot-master slight mismatch in Makefile... Message-ID: <20180815170013.a299dff7583871835ddc5651@bidouilliste.com> In-Reply-To: <20180813125611.GJ97145@funkthat.com> References: <20180813125611.GJ97145@funkthat.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 13 Aug 2018 05:56:11 -0700
John-Mark Gurney <jmg@funkthat.com> wrote:
> In the Makefile for u-boot-master:
> 63 # Overrides for ALLWINNER family
> 64 UBOOT_PLIST_ALLWINNER=u-boot-sunxi-with-spl.bin
> 65 UBOOT_METADATA_ALLWINNER_FILES= ${UBOOT_PLIST_ALLWINNER}
> 66 UBOOT_METADATA_ALLWINNER_METHOD= raw
> 67 UBOOT_METADATA_ALLWINNER_RAW_OFFSET= 8
> 68 UBOOT_METADATA_ALLWINNER_RAW_BS= 1k
> 69
> 70 # Overrides for ALLWINNER64 family
> 71 UBOOT_PLIST_ALLWINNER64=u-boot-sunxi-with-spl.bin
> 72 UBOOT_ARCH_ALLWINNER64=aarch64
> 73 UBOOT_METADATA_ALLWINNER64_FILES= ${UBOOT_PLIST_ALLWINNER}
>
> This last line should probably be:
> 73 UBOOT_METADATA_ALLWINNER64_FILES= ${UBOOT_PLIST_ALLWINNER64}
>
> and to make the change cascading since 71 and 64 are the same:
> 71 UBOOT_PLIST_ALLWINNER64=${UBOOT_PLIST_ALLWINNER}
>
> These changes won't change the behavior, but prevent POLA when someone
> changes UBOOT_PLIST_ALLWINNER64 and nothing changes...
>
> --
> John-Mark Gurney Voice: +1 415 225 5579
>
> "All that I will do, has been done, All that I have, has not."
> _______________________________________________
> freebsd-uboot@freebsd.org mailing list
> https://lists.freebsd.org/mailman/listinfo/freebsd-uboot
> To unsubscribe, send any mail to "freebsd-uboot-unsubscribe@freebsd.org"
Thanks,
Fixed in r477232.
--
Emmanuel Vadot <manu@bidouilliste.com> <manu@freebsd.org>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180815170013.a299dff7583871835ddc5651>