From owner-freebsd-bugs@freebsd.org Mon Dec 18 21:57:38 2017 Return-Path: Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 608FFE8BB90 for ; Mon, 18 Dec 2017 21:57:38 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4E7A0728BC for ; Mon, 18 Dec 2017 21:57:38 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id vBILvcKH060062 for ; Mon, 18 Dec 2017 21:57:38 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-bugs@FreeBSD.org Subject: [Bug 224437] [PATCH] powerpc64: Fix cookie verification on boot Date: Mon, 18 Dec 2017 21:57:38 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: patch X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: gromero@br.ibm.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status keywords bug_severity priority component assigned_to reporter attachments.created Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Dec 2017 21:57:38 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D224437 Bug ID: 224437 Summary: [PATCH] powerpc64: Fix cookie verification on boot Product: Base System Version: CURRENT Hardware: powerpc OS: Any Status: New Keywords: patch Severity: Affects Many People Priority: --- Component: kern Assignee: freebsd-bugs@FreeBSD.org Reporter: gromero@br.ibm.com Keywords: patch Created attachment 188943 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D188943&action= =3Dedit Patch for this bug Currently kernel fails to boot on PPC64 because the cookie value passed to kernel by the loader and which should be regarded as a 32-bit value is promoted on 64-bit machines to unsigned long (aka vm_offset_t) and thus results in 0xfffffffffb5d104d instead of 0xfb5d104d. That causes kernels to fail booting even if the loader is update to the most recent one by the user, i.e. user falls into "mountroot>" prompt and has to pass again the boot device to continue to boot process. So after a new kernel updated boot shows: Loader variables: Manual root filesystem specification: : [options] Mount using filesystem and with the specified (optional) option list. eg. ufs:/dev/da0s1a zfs:tank cd9660:/dev/cd0 ro (which is equivalent to: mount -t cd9660 -o ro /dev/cd0 /) ? List valid disk boot devices . Yield 1 second (for background tasks) Abort manual input mountroot>=20 That commit fixes that issue by ensuring that the cookie passed from loader to kernel is a 32-bit unsigned value both on PPC32 and PPC64 machines. --=20 You are receiving this mail because: You are the assignee for the bug.=