From owner-freebsd-ports@FreeBSD.ORG  Wed May 18 23:02:19 2011
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Delivered-To: freebsd-ports@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 8BB611065674
	for <freebsd-ports@freebsd.org>; Wed, 18 May 2011 23:02:19 +0000 (UTC)
	(envelope-from matt@conundrum.com)
Received: from coke.conundrum.com (coke.conundrum.com [216.235.9.139])
	by mx1.freebsd.org (Postfix) with ESMTP id 126FB8FC19
	for <freebsd-ports@freebsd.org>; Wed, 18 May 2011 23:02:18 +0000 (UTC)
Received: from bawls.conundrum.com (bawls.corp.conundrum.com [216.235.8.92]
	(may be forged))
	by coke.conundrum.com (8.13.1/8.12.6) with ESMTP id p4IN1dSQ053915;
	Wed, 18 May 2011 19:01:39 -0400 (EDT)
	(envelope-from matt@conundrum.com)
Received: from [216.235.10.34] ([216.235.10.34]) (authenticated bits=0)
	by bawls.conundrum.com (8.14.3/8.14.3) with ESMTP id p4IN1jsv075110;
	Wed, 18 May 2011 19:01:46 -0400 (EDT)
	(envelope-from matt@conundrum.com)
Mime-Version: 1.0 (Apple Message framework v1084)
Content-Type: text/plain; charset=us-ascii
From: Matthew Pounsett <matt@conundrum.com>
In-Reply-To: <4DD44B0D.5000402@infracaninophile.co.uk>
Date: Wed, 18 May 2011 19:01:31 -0400
Content-Transfer-Encoding: quoted-printable
Message-Id: <DB50B03B-38AA-49CA-B428-F736ED855A59@conundrum.com>
References: <C9301CD1-D2C0-449A-BD85-8488FDC028B5@conundrum.com>
	<4DD443DD.90909@infracaninophile.co.uk>
	<4DD44596.9050401@FreeBSD.org>
	<4DD44B0D.5000402@infracaninophile.co.uk>
To: Matthew Seaman <m.seaman@infracaninophile.co.uk>,
	Doug Barton <dougb@freebsd.org>
X-Mailer: Apple Mail (2.1084)
Cc: freebsd-ports@freebsd.org
Subject: Re: Optional Patches
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 18 May 2011 23:02:19 -0000


Based on the responses here it sounds like I've been doing nothing wrong =
so I played around a bit more.  I guess in my testing there must've been =
some combination of things I didn't get right... I did a bunch more =
testing and eventually I made it work doing exactly what I've been =
doing, except for the location of the ifdef.

It turns out that in order to make this work, the .if define must appear =
below where bsd.port.pre.mk is included.  If it occurs above that, I =
guess the definition of .if doesn't exist yet and so the block doesn't =
get run at all.

I don't recall seeing this restriction mentioned in the porters' =
handbook, but perhaps I missed it.

Thanks for the feedback.. sometimes just knowing it *should* work is =
enough to help lead one to the right bit of troubleshooting.

Cheers,
   Matt