From owner-svn-src-all@freebsd.org Sat Aug 18 06:24:13 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 231E210870ED for ; Sat, 18 Aug 2018 06:24:13 +0000 (UTC) (envelope-from gordon@tetlows.org) Received: from mail-qt0-x230.google.com (mail-qt0-x230.google.com [IPv6:2607:f8b0:400d:c0d::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id B71E1840EA for ; Sat, 18 Aug 2018 06:24:12 +0000 (UTC) (envelope-from gordon@tetlows.org) Received: by mail-qt0-x230.google.com with SMTP id y5-v6so11086411qti.12 for ; Fri, 17 Aug 2018 23:24:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tetlows.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=nLEusjOlMffqHU/ldZ+cWIZDZaUA/fr+rjR8fzUmIAU=; b=Pn+oQAvRYgyzwhDDWnp3hsSj/AHREm4WxYGQQoJDs0Vl6t1Zr4CntxOvqZBKAEVysJ ulEOAE5kVC12ZyPQttx+HASucWnysqhd8Izl6TSG7smUMHKm1uKIuMB/e6iAzX9mjQLT 4Jn6atiCuKj4JM3P1RqhPjBgqyMbj1EJtBC28= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=nLEusjOlMffqHU/ldZ+cWIZDZaUA/fr+rjR8fzUmIAU=; b=Fknq3XmVV+0rx2LTP3XoryUCGtJEv94Dw8VTboZPL2v4334nNC/8ge8MGaUNYmZNp6 D5XeDIZo4oyacMh4v9iQD0B+lq5UIw9lQ+jHmk4MsCZYrYVn0dWdfEZGmGG51EwPofMO DJy4y/UMwRln5WMDKPPg5WIqJDe+8lY5GnGIoYFXo6jcVI5kLWPZmuuxIOERbD3El42M KMYdOdV5krsLMJby1mqhp28/oFVmcE0vAzSX6T++FwlHBctbpGOofTy/vE/4yC4ApPlW a4F6mZyt2mNRmnPz2BWCSWBjAGK6p17Tcqo/dBkS/50GOd0kXudKTSc/NXGkREF/PMnP 8a9g== X-Gm-Message-State: AOUpUlFi12tIaIQ+8Bs3pLsJM3trjbyDyPs0IS2z4pq1S6Smfl5lerPl TqmwsFrLPHc2DbnvFlIuqjX0 X-Google-Smtp-Source: AA+uWPwZEEUgcK68qNpkoUPSaiYYKToQhUVpECIGhl8q5aTEQqCj5BDDL9zwW+mhQRkI3RtJ8ehG3Q== X-Received: by 2002:ac8:2a8f:: with SMTP id b15-v6mr36810176qta.405.1534573452038; Fri, 17 Aug 2018 23:24:12 -0700 (PDT) Received: from gmail.com ([2607:fc50:0:7900:0:dead:beef:cafe]) by smtp.gmail.com with ESMTPSA id y47-v6sm2758696qtk.27.2018.08.17.23.24.11 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 17 Aug 2018 23:24:11 -0700 (PDT) Date: Fri, 17 Aug 2018 23:24:09 -0700 From: Gordon Tetlow To: Conrad Meyer Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r337936 - in head/sys/contrib/libsodium: . builds builds/msvc builds/msvc/build builds/msvc/properties builds/msvc/vs2010 builds/msvc/vs2010/libsodium builds/msvc/vs2012 builds/msvc/vs2... Message-ID: <20180818062409.GA6651@gmail.com> References: <201808170023.w7H0Np0H027296@repo.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="LQksG6bCIzRHxTLp" Content-Disposition: inline In-Reply-To: <201808170023.w7H0Np0H027296@repo.freebsd.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 18 Aug 2018 06:24:13 -0000 --LQksG6bCIzRHxTLp Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Aug 17, 2018 at 12:23:51AM +0000, Conrad Meyer wrote: > Author: cem > Date: Fri Aug 17 00:23:50 2018 > New Revision: 337936 > URL: https://svnweb.freebsd.org/changeset/base/337936 >=20 > Log: > Bring in libsodium to sys/contrib > =20 > Bring in https://github.com/jedisct1/libsodium at > 461ac93b260b91db8ad957f5a576860e3e9c88a1 (August 7, 2018), unmodified. > =20 > libsodium is derived from Daniel J. Bernstein et al.'s 2011 NaCl > ("Networking and Cryptography Library," pronounced "salt") software lib= rary. > At the risk of oversimplifying, libsodium primarily exists to make it e= asier > to use NaCl. NaCl and libsodium provide high quality implementations o= f a > number of useful cryptographic concepts (as well as the underlying > primitics) seeing some adoption in newer network protocols. > =20 > I considered but dismissed cleaning up the directory hierarchy and > discarding artifacts of other build systems in favor of remaining close= to > upstream (and easing future updates). > =20 > Nothing is integrated into the build system yet, so in that sense, no > functional change. Hi! so@ here. Please don't integrate an additional crypto library without consultation from secteam. Bringing in a different crypto implementation has very serious downstream costs. Additionally, I don't see any discussion on current, hackers, arch, or security with a plan for why this is coming into the tree. That said, I've been on vacation the last two weeks, so if I missed something, please feel free to point it out to me. Thanks, Gordon --LQksG6bCIzRHxTLp Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGTBAABCgB9FiEEuyjUCzYO7pNq7RVv5fe8y6O93fgFAlt3u4BfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEJC MjhENDBCMzYwRUVFOTM2QUVEMTU2RkU1RjdCQ0NCQTNCRERERjgACgkQ5fe8y6O9 3fg0Qwf+NIuOpRcrCy9oDo5rzsqOOLUAf79uIWZTRWkwQI0OTkpwRbxsnkH7zubu Lfaq/76zIVYgmlC7swg3P3beEbFvLYNAMs9GZtiyfwNT+N8YNPTz5HFvWhp1pfOw QfWI0OIqetApLBinoMdVRd5YDKJb5np/eTJaIejQ4QXUZeqiHeDRp+yykRxyT6IY DbVDQDtEUj9w64HH2ijKCxzT/jYjEQ+Gd8vCEMhKWO1FT+5keomyquWgSw1AVKXF QBg4G4ANd59EF++y7Ms5iCLz+0nAIUEaZZrr2xM4iVMjuIsuiaBt+/rLzjOfhnON 54rpcR+XTZx9hMzXumcSnz1QyWvtyQ== =v7s7 -----END PGP SIGNATURE----- --LQksG6bCIzRHxTLp--