From owner-freebsd-bugs Thu Feb 8 18:30:28 2001 Delivered-To: freebsd-bugs@hub.freebsd.org Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by hub.freebsd.org (Postfix) with ESMTP id 4BD1437B65D for ; Thu, 8 Feb 2001 18:30:08 -0800 (PST) Received: (from gnats@localhost) by freefall.freebsd.org (8.11.1/8.11.1) id f192U8n59062; Thu, 8 Feb 2001 18:30:08 -0800 (PST) (envelope-from gnats) Date: Thu, 8 Feb 2001 18:30:08 -0800 (PST) Message-Id: <200102090230.f192U8n59062@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org Cc: From: Tony Finch Subject: Re: kern/24962: properly delay acks in half-closed TCP connections Reply-To: Tony Finch Sender: owner-freebsd-bugs@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org The following reply was made to PR kern/24962; it has been noted by GNATS. From: Tony Finch To: Garrett Wollman Cc: FreeBSD-gnats-submit@FreeBSD.ORG, Tony Finch Subject: Re: kern/24962: properly delay acks in half-closed TCP connections Date: Fri, 9 Feb 2001 02:23:54 +0000 Garrett Wollman wrote: >< said: > >> + (tp)->t_state >= TCPS_ESTABLISHED) { \ > >Should use the appropriate macro rather than assuming a particular >ordering on the TCP states. In this case, TCPS_HAVEESTABLISHED(state). I noticed later that NetBSD and OpenBSD have both inlined that macro at the single place it is invoked. Tony. -- f.a.n.finch fanf@covalent.net dot@dotat.at MALIN HEBRIDES BAILEY: VARIABLE BECOMING SOUTHEASTERLY 3 OR 4, INCREASING 6 OR 7, OCCASIONALLY GALE 8 IN BAILEY LATER. RAIN LATER. GOOD BECOMING MODERATE. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message