Date: Fri, 1 Oct 2021 13:57:32 +0200 From: Piotr Kubaj <pkubaj@anongoth.pl> To: Jan Beich <jbeich@freebsd.org> Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: fc75da3a3b2a - main - graphics/libjxl: fix build on powerpc64* Message-ID: <YVb3rG/VoShZaCbj@KGPE-D16> In-Reply-To: <sfxl-b428-wny@FreeBSD.org> References: <202109301550.18UFoo8j096475__2724.79643333412$1633017067$gmane$org@gitrepo.freebsd.org> <y27d-6dxe-wny@FreeBSD.org> <YVYq4DdMrnK6QTxI@KGPE-D16> <sfxl-b428-wny@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--fYWMURoXTPITeQXf Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable https://github.com/libjxl/libjxl/issues/677 On 21-10-01 09:24:31, Jan Beich wrote: > Piotr Kubaj <pkubaj@anongoth.pl> writes: >=20 > > On 21-09-30 21:50:21, Jan Beich wrote: > >> Piotr Kubaj <pkubaj@FreeBSD.org> writes: > >>=20 > >> > The include in cpu.cc is not actually necessary, so I did not in= clude anything for FreeBSD. > >> [...] > >> > +--- tools/cpu/cpu.cc.orig 2021-09-30 15:38:45 UTC > >> > ++++ tools/cpu/cpu.cc > >> > +@@ -19,7 +19,9 @@ > >> > + #endif > >> > +=20 > >> > + #if JXL_ARCH_PPC > >> > +-#include <sys/platform/ppc.h> // __ppc_get_timebase_freq > >> > ++#if linux > >> > ++#include <sys/platform/ppc.h> // NOLINT __ppc_get_timebase_freq > >> > ++#endif > >> > + #endif > >>=20 > >> Can you file a bug via https://github.com/libjxl/libjxl/issues/new ? > >> That include is probably unused even on Linux after 5175d11717f3 > >> removed __ppc_get_timebase_freq. > >>=20 > >> Note, if you can't sign Google CLA don't submit a fix. Otherwise, upst= ream > >> will refuse to read the rationale (PR description), let alone the patc= h e.g., > >> https://github.com/libjxl/libjxl/pull/193 > > > > No, I don't have a Google account. >=20 > It's not necessary for filing a bug. Doing so on your behalf is > complicated by not having powerpc64 hardware to verify fixes proposed > upstream and not having an error log/excerpt for upstream to better > understand what needs to be changed. >=20 > Outside of CLA upstream is very helpful. FreeBSD is officially supported > (see JXL_OS_FREEBSD) and fixed timely e.g., > https://gitlab.com/wg1/jpeg-xl/-/issues/65 > https://gitlab.com/wg1/jpeg-xl/-/issues/66 --=20 --fYWMURoXTPITeQXf Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEycyIeNkkgohzsoorelmbhSCDnJ0FAmFW96wACgkQelmbhSCD nJ1A/g//ULyL6uR8fJuo2jZIOTuhsIClOhCZYFrXACfAwuFCqylzdw3xidW2vHY0 j0mSe7QxPlcKgbw1f6O2f7e4yX3XcWGRgkg4HIw3pz5vSw68xerwLMCHQOi0nHB3 eKv10+FQzHaIPav651XSjVnX4qjnfUnZuScLyeGf5Lqj1dXDfMMrx7dRJlPJdSB+ 9ALBY4BUQdOan9+C0lTrBOfesq7ZhfGfhuQQKaj5ktzoVWBIvnmLyPCrb0ReiCDe KSKDMd06KnPNCJU8Dms9ylvKLKU2ZQTNaFyImPhxnAavn0s4kPfTFKo/qOyHDBUs P37Co+qO+N44J2qlx4H5XKEnWwm8Tbvm0C7Be4tOnGwhO5Grx3YVUJhgzMtktWJp RnwJE/pk68dxqlKG7BXfPn+2CzhNjAxk5qToSlsoJjlNVfhpOvyhwAxKF8E11dfQ I0DrO2FU5sATJ2nW9fdxI+iKyl73QeawVMYab2+nZre5Zu3XCmXfaDS0IvQSA6kh IC85fWmjKNeUe+fPOfGvmk4ZKZtdm7sHZd4LsSGr2E8FQy9npLFYRJi/bOyLqi0L /3niYVXigJAS73YCUsOHVbPLmty72zNONzUUFhsgkKRrZWqRV/8G17d1nujRZZ9l E240evkHFUQm+Bc2K4kOX2/5aI4IkSvml1yjNmyFiGNAEj6NcRg= =VPaz -----END PGP SIGNATURE----- --fYWMURoXTPITeQXf--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?YVb3rG/VoShZaCbj>