From owner-cvs-src@FreeBSD.ORG Fri May 30 14:56:42 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C0BA337B401 for ; Fri, 30 May 2003 14:56:42 -0700 (PDT) Received: from mail.speakeasy.net (mail15.speakeasy.net [216.254.0.215]) by mx1.FreeBSD.org (Postfix) with ESMTP id AC35943FAF for ; Fri, 30 May 2003 14:56:40 -0700 (PDT) (envelope-from jhb@FreeBSD.org) Received: (qmail 29507 invoked from network); 30 May 2003 21:56:39 -0000 Received: from unknown (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender )encrypted SMTP for ; 30 May 2003 21:56:39 -0000 Received: from laptop.baldwin.cx (gw1.twc.weather.com [216.133.140.1]) by server.baldwin.cx (8.12.8/8.12.8) with ESMTP id h4ULubp0088803; Fri, 30 May 2003 17:56:37 -0400 (EDT) (envelope-from jhb@FreeBSD.org) Message-ID: X-Mailer: XFMail 1.5.4 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <20030530200512.GE60607@sunbay.com> Date: Fri, 30 May 2003 17:56:37 -0400 (EDT) From: John Baldwin To: Ruslan Ermilov cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/security/mac_mls mac_mls.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 May 2003 21:56:43 -0000 On 30-May-2003 Ruslan Ermilov wrote: > On Fri, May 30, 2003 at 02:25:10PM -0400, John Baldwin wrote: >> >> On 30-May-2003 Robert Watson wrote: >> > rwatson 2003/05/30 10:02:37 PDT >> > >> > FreeBSD src repository >> > >> > Modified files: >> > sys/security/mac_mls mac_mls.c >> > Log: >> > Make sure all character pointers are properly initialized; this was >> > mismerged from the MAC tree, and didn't get picked up because warnings >> > are not normally fatal in per-module builds, only when they are linked >> > into a kernel (such as LINT). >> >> Can someone make module builds use the same warning flags and >> settings as kernel builds please? This same scenario has happened >> numerous times now. >> > This is not easy. For the kernel build, we have NORMAL_C and > NORMAL_C_NOWERROR (the former includes WERROR?= -Werror). > There are lot of files in sys/conf/files* that are marked with > "nowerror", and I'm sure they will break to compile as modules > with this patch, e.g., the acpi module has lot of files with > warnings: This is just a symptom of the problem that module Makefiles duplicate metadata in sys/conf/files (namely the list of files in a given module). The modules Makefile's should somehow be changed to get their list of files (as well as nowerror settings) from the sys/conf/files. Essentially, you almost want to build the acpi module like so: % cd modules/acpi % cat conf # ACPI module configuration device acpi % config conf ... generate makefiles, etc. ... % make ... compiles acpi.ko ... And avoid having to duplicate the metadata about what belongs in a module. Basically, you build a kernel that doesn't include standard and doesn't require a CPU keyword. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/