From nobody Wed Jul 8 18:10:02 2026 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gwR2f3cBKz6kcmX for ; Wed, 08 Jul 2026 18:10:02 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gwR2f1kPbz4Cwp for ; Wed, 08 Jul 2026 18:10:02 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1783534202; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=CosdIAHnXvcSAoEE1AcleEEv3TQ7CJWr30Nr3LUFdOM=; b=vTqnAvMrA8tuFTAjptG/v4v5sC5M0K5IX4oLqqkHbN3/1bNj+gspbuy9SxrVWv/D0dHIyN 0FQSVOM7nikEoFE7jRsBn6Ep01YfaFsTWwd2FjKn2+vt5jgTkdmIaVSDhDtVVDs1T3QJLB xxFfMoRf1dXYz9e1T9+HTK0ts8fc6jAgomz7trvatkQcLOan5pQqsacPp9AF4D+fwFpN2N un8bQvTtTkNPZFZhBlhxvZeq1A0NGaMy1Ucrofyay+iZW4LwO7Bv0lZZWY3DAX1bNSShTJ 1qaucsVd+54L+8BC1AJyJYxJLhjYsOF1Mk0Ag1rFXkBBqtebPngFV2+cT5wiig== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1783534202; a=rsa-sha256; cv=none; b=w7lKcR+TtB0V9F7fv3/NEjEWX9CzcpfX/YB9Mj9GKpkTlORgzKwzJONXjMypIQWui8/LkB KXREz8faZD86aWkDWwa0n08KCs034jeEaRf+/6ra6IZzVhzp0XUCP4O+e/0hIIOF8slpWh lysG9U5wMxpHD2q6Ksa3pMfhbxN79e4Ovsi6F1ehM5Zaal8TwbagoRVLeptzqGwflfDHF0 A0W4nSAcELNb5hQJURSJ+mvsc3D5aT/OguiSJiRwrC0OC4rqTfHh5vB3Vi/nOWd0PAo2bA NqdPav/TgSGF+aZswP4Eh3Xvt9ri9F2ns9hthBtm7aSmWt2dK8ghfOn1tjx6QQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1783534202; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=CosdIAHnXvcSAoEE1AcleEEv3TQ7CJWr30Nr3LUFdOM=; b=hWyPomtFWLYF4oCXKoapCPf9W8BsvOI9IpdtIvQE0hA18l7Kb79Z8Ux5M7LLMQn9ho6qxx r5eoqJpS9etAupSZxfam3OKc5DAfKAXZoNwYt1xh6ljN6NCW1h8+IVwvUshm/E2t7uzPMp 5aoYOt7ER2mf0fm7r/CtamqUM7GlWSlQJ4DzjRgtTsW+Q4tpqVESlBcZ0046q5gEPddfWC hoEGykFdYVn1I1lBO9ppBwVZW0YRONR8FMttaDzstahjwEHp/4jt+28ZF+9J3VdPHukqis RaGFfOT4TMnm3gb2aNe6zSSmFwb7Z+LHhY3QjvMsVTe7ytsEHY8Q2kPdh6hiTA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4gwR2f0P85zYw2 for ; Wed, 08 Jul 2026 18:10:02 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3907d by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 08 Jul 2026 18:10:02 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Mark Johnston Subject: git: c8cc44270404 - stable/15 - unix: Fix a socket refcount leak in uipc_sendfile_wait() List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: c8cc4427040443512411090b4bc75459c13b1ae6 Auto-Submitted: auto-generated Date: Wed, 08 Jul 2026 18:10:02 +0000 Message-Id: <6a4e927a.3907d.fd3efe4@gitrepo.freebsd.org> The branch stable/15 has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=c8cc4427040443512411090b4bc75459c13b1ae6 commit c8cc4427040443512411090b4bc75459c13b1ae6 Author: Mark Johnston AuthorDate: 2026-07-01 15:35:10 +0000 Commit: Mark Johnston CommitDate: 2026-07-08 18:09:35 +0000 unix: Fix a socket refcount leak in uipc_sendfile_wait() Fixes: d15792780760 ("unix: new implementation of unix/stream & unix/seqpacket") Reviewed by: glebius MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D57967 (cherry picked from commit 2a4b8fd1dc070e71fbaab6f12c1c9e4452652aa7) --- sys/kern/uipc_usrreq.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/sys/kern/uipc_usrreq.c b/sys/kern/uipc_usrreq.c index 87d7aa411b4d..bbea5ef3914c 100644 --- a/sys/kern/uipc_usrreq.c +++ b/sys/kern/uipc_usrreq.c @@ -2430,8 +2430,10 @@ uipc_sendfile_wait(struct socket *so, off_t need, int *space) SOCK_RECVBUF_UNLOCK(so2); return (EAGAIN); } - if (!sockref) + if (!sockref) { soref(so2); + sockref = true; + } error = uipc_stream_sbwait(so2, so->so_snd.sb_timeo); if (error == 0 && __predict_false(sb->sb_state & SBS_CANTRCVMORE))