From owner-cvs-all  Sun Nov 19 10:16:54 2000
Delivered-To: cvs-all@freebsd.org
Received: from warning.follo.net (warning.follo.net [195.204.136.30])
	by hub.freebsd.org (Postfix) with ESMTP
	id 922E137B4C5; Sun, 19 Nov 2000 10:16:48 -0800 (PST)
Received: (from eivind@localhost)
	by warning.follo.net (8.9.3/8.9.3) id TAA90528;
	Sun, 19 Nov 2000 19:16:18 +0100 (CET)
Date: Sun, 19 Nov 2000 19:16:18 +0100
From: Eivind Eklund <eivind@yes.no>
To: Brian Somers <brian@Awfulhak.org>
Cc: Kris Kennaway <kris@FreeBSD.org>, cvs-committers@FreeBSD.org,
	cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/libexec/pppoed pppoed.c
Message-ID: <20001119191618.A88885@warning.follo.net>
References: <kris@FreeBSD.org> <200011191755.eAJHtMQ68644@hak.lan.Awfulhak.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.4i
In-Reply-To: <200011191755.eAJHtMQ68644@hak.lan.Awfulhak.org>; from brian@Awfulhak.org on Sun, Nov 19, 2000 at 05:55:22PM +0000
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

On Sun, Nov 19, 2000 at 05:55:22PM +0000, Brian Somers wrote:
> > kris        2000/11/19 05:27:21 PST
> > 
> >   Modified files:
> >     libexec/pppoed       pppoed.c 
> >   Log:
> >   Format string paranoia
> >   
> >   Revision  Changes    Path
> >   1.6       +2 -2      src/libexec/pppoed/pppoed.c
> 
> This is indeed paranoia.  I'd say gratuitous even.

I'd disagree with you; it protects against later changes, and it
makes it easier to do quick checks for this kind of problem later.
"Unsafe" functions or constructs used safely takes time to check
each time somebody goes looking for that kind of problem.

Eivind.


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message