From owner-freebsd-x11@FreeBSD.ORG  Fri Jul 15 21:29:35 2005
Return-Path: <owner-freebsd-x11@FreeBSD.ORG>
X-Original-To: x11@FreeBSD.org
Delivered-To: freebsd-x11@FreeBSD.ORG
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 7435616A41C;
	Fri, 15 Jul 2005 21:29:35 +0000 (GMT) (envelope-from ade@FreeBSD.org)
Received: from mail.lovett.com (foo.lovett.com [67.134.38.158])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 14D1743D48;
	Fri, 15 Jul 2005 21:29:35 +0000 (GMT) (envelope-from ade@FreeBSD.org)
Received: from hellfire.lovett.com ([67.134.38.149]:51122)
	by mail.lovett.com with esmtpa (Exim 4.51 (FreeBSD))
	id 1DtXkU-000PrD-Px; Fri, 15 Jul 2005 14:29:34 -0700
Message-ID: <42D82ABF.40403@FreeBSD.org>
Date: Fri, 15 Jul 2005 14:29:35 -0700
From: Ade Lovett <ade@FreeBSD.org>
User-Agent: Mozilla Thunderbird 1.0.2 (Macintosh/20050317)
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: x11@FreeBSD.org
X-Enigmail-Version: 0.91.0.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Sender: freebsd@lovett.com
Cc: ade@FreeBSD.org
Subject: A proposal for extending X_*_PORT
X-BeenThere: freebsd-x11@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: X11 on FreeBSD -- maintaining and support <freebsd-x11.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-x11>,
	<mailto:freebsd-x11-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-x11>
List-Post: <mailto:freebsd-x11@freebsd.org>
List-Help: <mailto:freebsd-x11-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-x11>,
	<mailto:freebsd-x11-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 15 Jul 2005 21:29:35 -0000

Hi all,

Having had a quick conversation with lesi@ on IRC, I'm wondering about
extending the existing mechanisms for the X_*_PORT variables.

Currently, each port Makefile has to make a choice as to which actual
file to use to depend on to bring in the dependency, eg:

${X11BASE}/lib/X11/fonts/cyrillic/crox1c.pcf.gz:${X_FONTS_CYRILLIC_PORT}

The left hand side of this has two drawbacks, first that it requires an
awful lot of typing, and second, there is no consistency across port
Makefiles, which may make things fail rather badly if, in this case,
crox1c.pcf.gz disappeared from the plist of X_FONTS_CYRLLIC_PORT.

The proposed solution:

1.  For each X_*_PORT variable, there is an associated X_*_DEPENDS
variable, in this case it would be:

X_FONTS_CYRILLIC_DEPENDS= ${X11BASE}/lib/X11/fonts/cyrillic/crox1c.pcf.gz

All port Makefiles would then look like:

${X_FONTS_CYRILLIC_DEPENDS}:${X_FONTS_CYRILLIC_PORT}

and either of these variables would only have to be changed in one place
to update every single port in the tree that uses them.

2.  An extension of (1) above:

X_FONTS_CYRILLIC_DEPENDS=
${X11BASE}/lib/X11/fonts/cyrillic/crox1c.pcf.gz:${X_FONTS_CYRILLIC_PORT}

The port Makefile would then simply change to, eg:

RUN_DEPENDS= ${X_FONTS_CYRILLIC_DEPENDS}

The advantages here are less bits to type in the port Makefile, but it's
possible that portlint and friends would have to be updated to handle
this type of system (though it does already handle the common usage of
RUN_DEPENDS= ${BUILD_DEPENDS}

Thoughts?  Please do cc me on any followups, I have to try and keep my
subscriptions down to a fairly sane level, and this is more of an
infrastructal thing than an actual X11 issue.

Cheers,
	-aDe