From owner-freebsd-bugs@FreeBSD.ORG  Tue May 17 12:10:05 2005
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id D8CB716A4CE
	for <freebsd-bugs@hub.freebsd.org>;
	Tue, 17 May 2005 12:10:05 +0000 (GMT)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id B707A43D5C
	for <freebsd-bugs@hub.freebsd.org>;
	Tue, 17 May 2005 12:10:05 +0000 (GMT)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.13.3/8.13.3) with ESMTP id j4HCA5rQ079507
	for <freebsd-bugs@freefall.freebsd.org>; Tue, 17 May 2005 12:10:05 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.13.3/8.13.1/Submit) id j4HCA5NW079506;
	Tue, 17 May 2005 12:10:05 GMT
	(envelope-from gnats)
Date: Tue, 17 May 2005 12:10:05 GMT
Message-Id: <200505171210.j4HCA5NW079506@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
From: Ruslan Ermilov <ru@freebsd.org>
Subject: Re: kern/81147: em0 reinitialization while adding aliases to
	interface
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
Reply-To: Ruslan Ermilov <ru@freebsd.org>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 17 May 2005 12:10:06 -0000

The following reply was made to PR kern/81147; it has been noted by GNATS.

From: Ruslan Ermilov <ru@freebsd.org>
To: Dmitry Sergienko <dmitry@trifle.net>
Cc: FreeBSD-gnats-submit@freebsd.org
Subject: Re: kern/81147: em0 reinitialization while adding aliases to interface
Date: Tue, 17 May 2005 15:06:56 +0300

 On Tue, May 17, 2005 at 12:55:57PM +0300, Dmitry Sergienko wrote:
 > Network card looses link while adding an alias to interface em0.
 > This affects only em0 - neither vlans with vlandev em0, nor fxp0.
 > Problem was detected on two different machines with the same netcards
 > 
 This simple patch works for me:
 
 %%%
 Index: if_em.c
 ===================================================================
 RCS file: /home/ncvs/src/sys/dev/em/if_em.c,v
 retrieving revision 1.63
 diff -u -p -r1.63 if_em.c
 --- if_em.c	5 Apr 2005 07:06:47 -0000	1.63
 +++ if_em.c	14 Apr 2005 19:03:36 -0000
 @@ -832,12 +832,14 @@ em_init_locked(struct adapter * adapter)
          bcopy(adapter->interface_data.ac_enaddr, adapter->hw.mac_addr,
                ETHER_ADDR_LEN);
  
 +#if 0
  	/* Initialize the hardware */
  	if (em_hardware_init(adapter)) {
  		printf("em%d: Unable to initialize the hardware\n", 
  		       adapter->unit);
  		return;
  	}
 +#endif
  
  	if (ifp->if_capenable & IFCAP_VLAN_HWTAGGING)
  		em_enable_vlans(adapter);
 %%%
 
 
 -- 
 Ruslan Ermilov
 ru@FreeBSD.org
 FreeBSD committer