From owner-svn-src-head@freebsd.org Tue Jan 7 08:39:46 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 7BB731F4A85 for ; Tue, 7 Jan 2020 08:39:46 +0000 (UTC) (envelope-from marklmi@yahoo.com) Received: from sonic313-21.consmr.mail.gq1.yahoo.com (sonic313-21.consmr.mail.gq1.yahoo.com [98.137.65.84]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 47sQmK40pVz3NJ5 for ; Tue, 7 Jan 2020 08:39:45 +0000 (UTC) (envelope-from marklmi@yahoo.com) X-YMail-OSG: domZ99IVM1m08hAogKNF1ZdP_DabPfnjfJxnIwUVh.6n4scDndvvGnLFk736B2i rGjKz_6UYxaQ5uB_cCvh5xe4e6oh3OW2fqUBg71qUc1cqhMyA8vZkzmvpTA4HXAyEOmALu03Ii_A .1pj6gPgyMSRmgrh3c5zANgVE.Njm6w86k1RA1GKt4UFrbX8ocKueBjnlCLeO90PjEQrl9U6FObZ N8n_lziRfpwHzCjwdFaQvEi79yHaus1JunocjmB3siVL3485yPqdiEv1JwHGVacxnECmqSj3PHH2 pkEn0dyqDjwk0hGk66Zx6TlWUqYhhEX3cx5_3BrLKbGVLRZjqLx1BxqRqA61FaDbtZKcCJhg0fvN m2RNay6yCDlUaunKnKBZsjaI1M5kK.lEnpIdTVN.4Zkp6jtPaTS1SHkhjAE8diHTD3vaC7f6Rr16 v2TjaNI44Bo3aIPAmaY3PiLquKVTWsnnHNTWCuCNUlHA94fPHSBLwICakBBISEOhdZoxkV6vG3HZ HWUhvTOHkENYPI9.SDOFKl.gWAHy0oroQpu2XGmEvSbo4b1ogkyXYF7vgxg8X09.3R8I91P0eKU7 6FwMguX5PMF8_UxYokQuXiGKxpfeKolOxgIhhtYr1spepFTLv0corDiEgU3sYAEtlLhlHW52gOaZ DrbCll01oSo3S0EAENJnNNfXS5PA1hroXo3tGizwk9P5Y2lBvgkO_knXQfFl.XqlMQxr88W3Ewr4 DMp.O_WE8X2X5PX0H.07YDgFshds4REQ3f9WNDo_DXKdioiqJCc4p9erbjUm7QwiLKYEzCgPIcsS sRZ_vrtfk8nPI7VtjqYPXEO.RKgalXSInmVAWF7RLFxtJYa3MELLBcQuuljVQj3t378YCGMc16iS w1S3I53xwGdtfE0uv8gZkf6iZrDSdYSYfA2MucxHS3YKsjNRwqtmNb8_Y_SQ.azHROrmdqdTPSkm Vw7DUs2MN.QCs6v6ZCkl8BIob8Z3OtxVNB.YStka5ONj.ILL5ZkpRg33taoRYBbW6XekiABp6x5L kfpIhtiKSf_5Mhoqxgv1PW9Ue.pPJRFlOkYjNtAE9PUyYqT.o7wNfpTEgJzFftmRvYh.r1YrrNdE 5ox8o2tAhpmR1vI0Qq3vMC5vCG3ehBFwhKJNvsgI5CIIlc8bjZNityFOXA1hBkgHmHDiDshPaEZf ICg511TfS.4VGQOT1v4ZdBTH.hkOqYWhN1HSrnAfKbdt91HyJm4CvXMLMRDjyN0_.ZBAgBxdnfL8 qa_fYWtHK40ZE6ZmOTrbvQU9v36wCEPcAQGpF5tT9eKhlqoZcsS8GSJocqUorOeRgMx4do1FzgWm AOclI4RShS2F_ygMgpoGCjFcVGtanTriqC_8_.UepSuVbW7h7CzBpN0YODY2I3hqb5RGicVnbw9a ETiIPv6RoCoiWvdEsR6kdM642JFX4B9I- Received: from sonic.gate.mail.ne1.yahoo.com by sonic313.consmr.mail.gq1.yahoo.com with HTTP; Tue, 7 Jan 2020 08:39:43 +0000 Received: by smtp429.mail.bf1.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID f38111a93bdf34884a650323ae2005c6; Tue, 07 Jan 2020 08:39:38 +0000 (UTC) From: Mark Millard Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 13.0 \(3608.40.2.2.4\)) Subject: Re: svn commit: r356437 - head/lib/libprocstat Message-Id: Date: Tue, 7 Jan 2020 00:39:36 -0800 To: "mjg@freebsd.org " , svn-src-head@freebsd.org X-Mailer: Apple Mail (2.3608.40.2.2.4) References: X-Rspamd-Queue-Id: 47sQmK40pVz3NJ5 X-Spamd-Bar: -- X-Spamd-Result: default: False [-2.34 / 15.00]; TO_DN_EQ_ADDR_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ptr:yahoo.com]; FREEMAIL_FROM(0.00)[yahoo.com]; MV_CASE(0.50)[]; DKIM_TRACE(0.00)[yahoo.com:+]; RCPT_COUNT_TWO(0.00)[2]; DMARC_POLICY_ALLOW(-0.50)[yahoo.com,reject]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[yahoo.com]; ASN(0.00)[asn:36647, ipnet:98.137.64.0/21, country:US]; MID_RHS_MATCH_FROM(0.00)[]; DWL_DNSWL_NONE(0.00)[yahoo.com.dwl.dnswl.org : 127.0.5.0]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-0.86)[-0.862,0]; R_DKIM_ALLOW(-0.20)[yahoo.com:s=s2048]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-0.98)[-0.976,0]; MIME_GOOD(-0.10)[text/plain]; RCVD_TLS_LAST(0.00)[]; IP_SCORE_FREEMAIL(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[84.65.137.98.list.dnswl.org : 127.0.5.0]; IP_SCORE(0.00)[ip: (1.13), ipnet: 98.137.64.0/21(0.88), asn: 36647(0.70), country: US(-0.05)]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Jan 2020 08:39:46 -0000 (Derived from O. Hartmann's report, despite his not having the same source version, . . .) In the code: 823 static struct filestat_list * 824 procstat_getfiles_sysctl(struct procstat *procstat, struct = kinfo_proc *kp, 825 int mmapped) 826 { 827 struct kinfo_file *kif, *files; . . . 841 switch(procstat->type) { 842 case PROCSTAT_SYSCTL: 843 files =3D kinfo_getfile(kp->ki_pid, &cnt); 844 break; 845 case PROCSTAT_CORE: 846 files =3D kinfo_getfile_core(procstat->core, = &cnt); 847 break; 848 default: 849 assert(!"invalid type"); 850 } 851 if (files =3D=3D NULL && errno !=3D EPERM) { 852 for the "default:" case, if assert is disabled to be a no-op via NDEBUG, then files would be tested in an uninitialized state. The compiler complaint seems valid for this. =3D=3D=3D Mark Millard marklmi at yahoo.com ( dsl-only.net went away in early 2018-Mar)