From owner-cvs-all Mon Dec 11 17:20:52 2000 From owner-cvs-all@FreeBSD.ORG Mon Dec 11 17:20:49 2000 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from fw.wintelcom.net (ns1.wintelcom.net [209.1.153.20]) by hub.freebsd.org (Postfix) with ESMTP id 29B4C37B400; Mon, 11 Dec 2000 17:20:49 -0800 (PST) Received: (from bright@localhost) by fw.wintelcom.net (8.10.0/8.10.0) id eBC1Km821646; Mon, 11 Dec 2000 17:20:48 -0800 (PST) Date: Mon, 11 Dec 2000 17:20:48 -0800 From: Alfred Perlstein To: Jake Burkholder Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/conf files src/sys/sys mutex.h src/sys/kern kern_mutex.c src/sys/i386/i386 trap.c src/sys/ia64/ia64 trap.c src/sys/alpha/alpha trap.c Message-ID: <20001211172048.R16205@fw.wintelcom.net> References: <200012120114.eBC1EXs04634@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <200012120114.eBC1EXs04634@freefall.freebsd.org>; from jake@FreeBSD.org on Mon, Dec 11, 2000 at 05:14:33PM -0800 Sender: bright@fw.wintelcom.net Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG * Jake Burkholder [001211 17:14] wrote: > jake 2000/12/11 17:14:33 PST > > Modified files: > sys/conf files > sys/sys mutex.h > sys/kern kern_mutex.c > sys/i386/i386 trap.c > sys/ia64/ia64 trap.c > sys/alpha/alpha trap.c > Log: > - Add code to detect if a system call returns with locks other than Giant > held and panic if so (conditional on witness). Why not conditional on INVARIANTS? Couldn't this be easily tracked via a counter in the proc struct? I'm trying to find a middle ground where the debug code doesn't make development unbearable because of the slowdown. MUTEX_DEBUG and WITNESS make compiling kernels (actually IO) too slow to be tolerated. -- -Alfred Perlstein - [bright@wintelcom.net|alfred@freebsd.org] "I have the heart of a child; I keep it in a jar on my desk." To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message