From owner-cvs-src@FreeBSD.ORG Thu Nov 15 20:39:22 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6F64416A505; Thu, 15 Nov 2007 20:39:22 +0000 (UTC) (envelope-from remko@elvandar.org) Received: from galain.elvandar.org (galain.elvandar.org [217.148.169.56]) by mx1.freebsd.org (Postfix) with ESMTP id 1D71A13C469; Thu, 15 Nov 2007 20:39:21 +0000 (UTC) (envelope-from remko@elvandar.org) Received: from localhost ([127.0.0.1] helo=galain.elvandar.org) by galain.elvandar.org with esmtpa (Exim 4.67) (envelope-from ) id 1IslUW-0000ZR-Lt; Thu, 15 Nov 2007 21:39:12 +0100 Received: from 195.64.94.120 (SquirrelMail authenticated user remko) by galain.elvandar.org with HTTP; Thu, 15 Nov 2007 21:39:12 +0100 (CET) Message-ID: <64387.195.64.94.120.1195159152.squirrel@galain.elvandar.org> Date: Thu, 15 Nov 2007 21:39:12 +0100 (CET) From: "Remko Lodder" To: "Steve Kargl" User-Agent: SquirrelMail/1.4.11 MIME-Version: 1.0 Content-Type: text/plain;charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Priority: 3 (Normal) Importance: Normal Cc: Scott Long , src-committers@freebsd.org, cvs-src@freebsd.org, cvs-all@freebsd.org, Gleb Smirnoff , Robert Watson , Julian Elischer Subject: Re: cvs commit: src/sys/kern kern_kse.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: remko@elvandar.org List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Nov 2007 20:39:22 -0000 On Thu, November 15, 2007 9:30 pm, Steve Kargl wrote: > On Thu, Nov 15, 2007 at 01:08:03PM -0700, Scott Long wrote: >> Robert Watson wrote: >> >On Thu, 15 Nov 2007, Julian Elischer wrote: >> >>>>"no matter how small the change, use diff + patch to move it >> across." >> >>> >> >>>After applying the patch on your commit machine, is it too difficult >> >>>to actually retest before committing? This would catch the broken >> >>>commit before it becomes a Tinderbox issue. >> >>> >> >>>Seems to be a QA problem on your part. >> >> >> >>yes.. but I can't do a compile from my mac. (my commit machine). The >> >>answer is to be rigorous about how I move the patch from the build >> >>machine to the commit machine. >> >> >> >>This is a temporary situation. new infrastructure will let me commit >> >>from my build machine again. >> > >> >I find having a copy of Parallels (or VMWare) around very useful for >> >precisely this situation -- it means that even when I have only the Mac >> >around I can easily do a local test build. The various VM packages >> >certainly have their limitations, but they're far better than nothing. >> >> And to be fair, there are habitual build breakers and there are >> non-habitual build breakers. Julian, IMHO, falls mostly into the >> latter category, yet I see people focus on him disproportionally. >> Funny. Kinda. Not. > > I'm not focusing on Julian. I'm focusing on the process. No one > should be committing a patch that touchs functioning code to src/ > without proper testing. Moving a patch from a build machine to > a commit machine and then having to hand apply the patch is prone > to error. > > -- > Steve > And we all make mistakes and things like that Just Happen [tm]. I think that most patches are tested very well in between and the fact that we dont have a lot of breakages (at least not in my experience) proves that. No need to sharpen the rules or something, the world is already one sharp rule :-) Cheers remko -- /"\ Best regards, | remko@FreeBSD.org \ / Remko Lodder | remko@EFnet X http://www.evilcoder.org/ | / \ ASCII Ribbon Campaign | Against HTML Mail and News