From owner-cvs-src@FreeBSD.ORG  Tue Apr  8 10:11:44 2003
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 8CE7037B404
	for <cvs-src@FreeBSD.org>; Tue,  8 Apr 2003 10:11:44 -0700 (PDT)
Received: from rootlabs.com (root.org [67.118.192.226])
	by mx1.FreeBSD.org (Postfix) with SMTP id 30D3243FCB
	for <cvs-src@FreeBSD.org>; Tue,  8 Apr 2003 10:11:43 -0700 (PDT)
	(envelope-from nate@rootlabs.com)
Received: (qmail 27475 invoked by uid 1000); 8 Apr 2003 17:11:43 -0000
Date: Tue, 8 Apr 2003 10:11:43 -0700 (PDT)
From: Nate Lawson <nate@root.org>
To: Maxime Henrion <mux@FreeBSD.org>
In-Reply-To: <20030408130518.AD52137B496@hub.freebsd.org>
Message-ID: <Pine.BSF.4.21.0304081010230.27414-100000@root.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/dev/fxp if_fxp.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 08 Apr 2003 17:11:45 -0000

On Tue, 8 Apr 2003, Maxime Henrion wrote:
>   Modified files:
>     sys/dev/fxp          if_fxp.c 
>   Log:
>   Fix the hangs people have been seeing.  For some reason, the
>   atomic operation change caused this, so backout it until I
>   can figure out what's wrong with it.
>   
>   Revision  Changes    Path
>   1.163     +7 -11     src/sys/dev/fxp/if_fxp.c

Thank you. 

> -		atomic_clear_32((u_int32_t *)&last->tx_cb->cb_status,
> -		    htobe32(bswap16(FXP_CB_COMMAND_S)));
> -
> +		atomic_clear_short(&sc->fxp_desc.tx_last->tx_cb->cb_command,
> +		    FXP_CB_COMMAND_S);
> +#else
> +		sc->fxp_desc.tx_last->tx_cb->cb_command &= ~FXP_CB_COMMAND_S;
> +#endif /*__alpha__*/

Um, are each of those cases semantically equivalent?

-Nate