Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 8 Apr 2003 10:11:43 -0700 (PDT)
From:      Nate Lawson <nate@root.org>
To:        Maxime Henrion <mux@FreeBSD.org>
Cc:        cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/sys/dev/fxp if_fxp.c
Message-ID:  <Pine.BSF.4.21.0304081010230.27414-100000@root.org>
In-Reply-To: <20030408130518.AD52137B496@hub.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 8 Apr 2003, Maxime Henrion wrote:
>   Modified files:
>     sys/dev/fxp          if_fxp.c 
>   Log:
>   Fix the hangs people have been seeing.  For some reason, the
>   atomic operation change caused this, so backout it until I
>   can figure out what's wrong with it.
>   
>   Revision  Changes    Path
>   1.163     +7 -11     src/sys/dev/fxp/if_fxp.c

Thank you. 

> -		atomic_clear_32((u_int32_t *)&last->tx_cb->cb_status,
> -		    htobe32(bswap16(FXP_CB_COMMAND_S)));
> -
> +		atomic_clear_short(&sc->fxp_desc.tx_last->tx_cb->cb_command,
> +		    FXP_CB_COMMAND_S);
> +#else
> +		sc->fxp_desc.tx_last->tx_cb->cb_command &= ~FXP_CB_COMMAND_S;
> +#endif /*__alpha__*/

Um, are each of those cases semantically equivalent?

-Nate



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.21.0304081010230.27414-100000>