From owner-svn-ports-head@FreeBSD.ORG  Fri Feb 28 20:11:38 2014
Return-Path: <owner-svn-ports-head@FreeBSD.ORG>
Delivered-To: svn-ports-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 2CA8EEC5;
 Fri, 28 Feb 2014 20:11:38 +0000 (UTC)
Received: from apnoea.adamw.org (apnoea.adamw.org [204.109.59.150])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id 8DB981312;
 Fri, 28 Feb 2014 20:11:37 +0000 (UTC)
Received: from [192.168.2.1] (dhcp-108-170-169-46.cable.user.start.ca
 [108.170.169.46])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by apnoea.adamw.org (Postfix) with ESMTPSA id 7007911FC16;
 Fri, 28 Feb 2014 15:11:26 -0500 (EST)
From: "Adam Weinberger" <adamw@adamw.org>
To: "Tijl Coosemans" <tijl@FreeBSD.org>
Subject: Re: svn commit: r346570 - head/mail/squirrelmail
Date: Fri, 28 Feb 2014 15:11:20 -0500
Message-ID: <E30C30A6-ED8C-489F-AD49-7B06D260BAD8@adamw.org>
In-Reply-To: <20140228205412.17dead83@kalimero.tijl.coosemans.org>
References: <201402281928.s1SJSOFd043779@svn.freebsd.org>
 <20140228205412.17dead83@kalimero.tijl.coosemans.org>
MIME-Version: 1.0
Content-Type: text/plain; format=flowed
Content-Transfer-Encoding: quoted-printable
X-Mailer: MailMate (1.7.2r4025)
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 Adam Weinberger <adamw@FreeBSD.org>, ports-committers@freebsd.org
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 28 Feb 2014 20:11:38 -0000

On 28 Feb 2014, at 14:54, Tijl Coosemans wrote:

> On Fri, 28 Feb 2014 19:28:24 +0000 (UTC) Adam Weinberger wrote:
>> 	${CHMOD} 730 ${STAGEDIR}${SQUIRRELDIR}/attach
>> 	${CHMOD} 750 ${STAGEDIR}${SQUIRRELDIR}/data
>
> I think you can remove the chmod commands too...
>
>
>> Modified: head/mail/squirrelmail/pkg-plist
>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D
>> --- head/mail/squirrelmail/pkg-plist	Fri Feb 28 19:14:42 =

>> 2014	(r346569)
>> +++ head/mail/squirrelmail/pkg-plist	Fri Feb 28 19:28:23 =

>> 2014	(r346570)
>> @@ -1,5 +1,7 @@
>> etc/periodic/daily/111.clean-squirrelmail
>> %%SQUIRRELDIR%%/attach/.htaccess
>> +@exec chown %%SMUSER%%:%%SMGROUP%% %B
>> +@exec chmod 730 %B
>
> ...if you do this as follows:
>
> @owner %%SMUSER%%
> @group %%SMGROUP%%
> @mode 730
> %%SQUIRRELDIR%%/attach/.htaccess
> @owner
> @group
> @mode
>
> Are you sure that 3 for group permissions is correct?
>
>> +@exec chown %%SMUSER%%:%%SMGROUP%% %B
>> +@exec chmod 750 %B
>
> Same here, but you could also group it with the .htaccess file above.
>
> The pkg-plist format is explained in the pkg-create manpage by the =

> way.

%B refers to the dirname. Your suggestion would change the ownership and =

permissions of the .htaccess file, which would then require an @exec =

chown and @exec chmod to repair, so it wouldn't really fix anything.

# Adam


--
Adam Weinberger
adamw@adamw.org
http://www.adamw.org