From owner-freebsd-ports@FreeBSD.ORG Tue Jan 20 10:21:59 2004 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B95BE16A4D0; Tue, 20 Jan 2004 10:21:59 -0800 (PST) Received: from creme-brulee.marcuscom.com (rrcs-midsouth-24-172-16-118.biz.rr.com [24.172.16.118]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5505943D55; Tue, 20 Jan 2004 10:20:50 -0800 (PST) (envelope-from marcus@FreeBSD.org) Received: from [10.2.1.4] (vpn-client-4.marcuscom.com [10.2.1.4]) i0KIJAsm062905; Tue, 20 Jan 2004 13:19:10 -0500 (EST) (envelope-from marcus@FreeBSD.org) From: Joe Marcus Clarke To: Oliver Eikemeier In-Reply-To: <400D7077.30009@fillmore-labs.com> References: <1074590694.85583.20.camel@shumai.marcuscom.com> <400D2939.5090203@fillmore-labs.com> <1074617147.757.16.camel@gyros> <20040120171315.GH94636@FreeBSD.org> <1074619795.757.43.camel@gyros> <400D68A1.4030501@fillmore-labs.com> <1074620919.757.51.camel@gyros> <20040120175136.GC3365@toxic.magnesium.net> <400D6D8F.7010708@fillmore-labs.com> <1074621945.757.63.camel@gyros> <400D7077.30009@fillmore-labs.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-eyGooDOBKCpkgRoh3TCP" Organization: FreeBSD, Inc. Message-Id: <1074622845.757.69.camel@gyros> Mime-Version: 1.0 X-Mailer: Ximian Evolution 1.4.5 Date: Tue, 20 Jan 2004 13:20:45 -0500 X-Spam-Status: No, hits=-4.9 required=5.0 tests=BAYES_00 autolearn=ham version=2.61 X-Spam-Checker-Version: SpamAssassin 2.61 (1.212.2.1-2003-12-09-exp) on creme-brulee.marcuscom.com cc: ports@FreeBSD.org cc: Eivind Eklund cc: Adam Weinberger cc: Kris Kennaway Subject: Re: HEADS UP: New bsd.*.mk changes X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Jan 2004 18:22:00 -0000 --=-eyGooDOBKCpkgRoh3TCP Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Tue, 2004-01-20 at 13:16, Oliver Eikemeier wrote: > Joe Marcus Clarke wrote: >=20 > > On Tue, 2004-01-20 at 13:03, Oliver Eikemeier wrote: > >=20 > >>Adam Weinberger wrote: > >> > >> > >>>>>(01.20.2004 @ 1248 PST): Joe Marcus Clarke said, in 3.9K: << > >>>>>Can we at least have > >>>>> > >>>>>OPTIONSNAME?=3D${PKGNAMEPREFIX}${PORTNAME} > >>>>> > >>>>>here? It makes sense for all the localized ports, perl, ruby, python= , linux > >>>>>and others. > >>>> > >>>>That makes sense...maybe having the whole trifecta is a good idea, to= o: > >>>>${PKGNAMEPREFIX}${PORTNAME}${PKGNAMESUFFIX} > >>>> > >>>>And what about UNIQUENAME instead of OPTIONSNAME? This way, it could= be > >>>>used for other purposes. > >>>> > >>>> > >>>>>end of "Re: HEADS UP: New bsd.*.mk changes" from Joe Marcus Clarke <= < > >>> > >>> > >>>If all you're going for is a unique identifier for each port, this is > >>>guaranteed unique: > >>> > >>>${.CURDIR:S@${PORTSDIR}@@:S@/@_@g} > >>> > >>>x11_gnome2, etc. > >> > >>Sorry to bring it up again, LATEST_LINK is designed to do what we want,= it > >>has just a stupid name... > >> > >>Look at > >> > >>all packages in one directory, no collisions, version independend. It e= ven > >>survives renaming / category changes. > >=20 > > Except not every port creates a LATEST_LINK. >=20 > Not every port creates PKGLATESTFILE (${PKGLATESTREPOSITORY}/${LATEST_LIN= K}${PKG_SUFX}). > Every port sets the variable LATEST_LINK (by default to > ${PKGBASE}=3D${PKGNAMEPREFIX}${PORTNAME}${PKGNAMESUFFIX}), and ports that= need to > override it with something suitable (openldap, apache). Only the ports th= at build > no packages (like the jdk ports) don't care and have the same LATEST_LINK= . >=20 > I totally agree that nobody want to use a variable called 'LATEST_LINK' u= sed for that > purpose, but, hey, it's just a name. If we use something like > OPTIONSNAME?=3D${LATEST_LINK} > we have to use an workaround only for the port that build no packages, th= e rest should > be automagically right. All the work of thinking of an unique name has al= ready been done > for a lot of ports. Yes, sorry I've missed some of these points. I'm trying to balance real work and this discussion. You're right that we could just "borrow" LATEST_LINK for the options purpose, but it will require your re-ordering patch that will require testing on bento. So, the way I see it, we could keep things the way they are and wait for the next experimental build cycle, or commit a UNIQUENAME patch that is temporary until LATEST_LINK can be evaluated. Once that gets decided, we can PR the patch we want tested. Joe --=20 Joe Marcus Clarke FreeBSD GNOME Team :: marcus@FreeBSD.org gnome@FreeBSD.org FreeNode / #freebsd-gnome http://www.FreeBSD.org/gnome --=-eyGooDOBKCpkgRoh3TCP Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (FreeBSD) iD8DBQBADXF9b2iPiv4Uz4cRAoAnAJ9EjSlfPN6LdL9AFzGktKpYAKs3AgCgmEGP 9may8XglFP8aKHkZO7Mw3YM= =0dmf -----END PGP SIGNATURE----- --=-eyGooDOBKCpkgRoh3TCP--