From owner-cvs-src@FreeBSD.ORG Fri Jul 11 00:51:12 2008 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E2D811065676; Fri, 11 Jul 2008 00:51:12 +0000 (UTC) (envelope-from obrien@NUXI.org) Received: from dragon.nuxi.org (trang.nuxi.org [74.95.12.85]) by mx1.freebsd.org (Postfix) with ESMTP id BFF338FC14; Fri, 11 Jul 2008 00:51:12 +0000 (UTC) (envelope-from obrien@NUXI.org) Received: from dragon.nuxi.org (obrien@localhost [127.0.0.1]) by dragon.nuxi.org (8.14.2/8.14.2) with ESMTP id m6B0pCj4071412; Thu, 10 Jul 2008 17:51:12 -0700 (PDT) (envelope-from obrien@dragon.nuxi.org) Received: (from obrien@localhost) by dragon.nuxi.org (8.14.2/8.14.2/Submit) id m6B0pCMK071411; Thu, 10 Jul 2008 17:51:12 -0700 (PDT) (envelope-from obrien) Date: Thu, 10 Jul 2008 17:51:12 -0700 From: "David O'Brien" To: Peter Wemm Message-ID: <20080711005112.GA60061@dragon.NUXI.org> References: <200807101635.m6AGZv7I090311@svn.freebsd.org> <20080710233721.GA55073@dragon.NUXI.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Operating-System: FreeBSD 8.0-CURRENT User-Agent: Mutt/1.5.16 (2007-06-09) Cc: cvs-src@freebsd.org, src-committers@freebsd.org, "cvs-all@freebsd.org" Subject: Re: svn commit: r180431 - in head/sys: kern sys X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: obrien@freebsd.org List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Jul 2008 00:51:13 -0000 On Thu, Jul 10, 2008 at 04:58:05PM -0700, Peter Wemm wrote: > On Thu, Jul 10, 2008 at 4:37 PM, David O'Brien wrote: > > On Thu, Jul 10, 2008 at 10:35:35AM -0700, Peter Wemm wrote: > >> On Thu, Jul 10, 2008 at 9:35 AM, David E. O'Brien wrote: > >> > Author: obrien > >> > Date: Thu Jul 10 16:35:57 2008 > >> > New Revision: 180431 > >> > URL: http://svn.freebsd.org/changeset/base/180431 > >> > > >> > Log: > >> > Allow 'elf_file_t' to be used in a wider scope. > >> > > >> > Modified: > >> > head/sys/kern/link_elf.c > >> > head/sys/sys/link_elf.h > >> > >> This really was intentional. elf_file_t was supposed to be opaque and > >> changeable. What do you need this for? > > > > Juniper needs to be able to call functions in the loadable modules before > > the modules are actually linked into the kernel. This will be used to > > call platform specific initialization functions early in the bootup > > process. Will also need un-static link_elf_preload_parse_symbols, > > parse_dynamic, symbol_name, link_elf_lookup_symbol, > > link_elf_symbol_values. > > I think you should leave it in Juniper's tree for a tad longer: > ../../../kern/link_elf_obj.c:88: error: redefinition of 'struct elf_file' > ../../../kern/link_elf_obj.c:119: error: redefinition of typedef 'elf_file_t' > ../../../sys/link_elf.h:133: error: previous declaration of > 'elf_file_t' was here What arch are you building on? I built i386 LINT with this change. So I need some help reproducing the build break. -- -- David (obrien@FreeBSD.org)