From owner-freebsd-stable@FreeBSD.ORG  Thu Jan 17 07:33:09 2013
Return-Path: <owner-freebsd-stable@FreeBSD.ORG>
Delivered-To: freebsd-stable@freebsd.org
Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115])
 by hub.freebsd.org (Postfix) with ESMTP id 5BEBAC0C
 for <freebsd-stable@freebsd.org>; Thu, 17 Jan 2013 07:33:09 +0000 (UTC)
 (envelope-from mauzo@anubis.morrow.me.uk)
Received: from isis.morrow.me.uk (isis.morrow.me.uk [204.109.63.142])
 by mx1.freebsd.org (Postfix) with ESMTP id 3A1E79BD
 for <freebsd-stable@freebsd.org>; Thu, 17 Jan 2013 07:33:08 +0000 (UTC)
Received: from anubis.morrow.me.uk
 (host109-150-212-220.range109-150.btcentralplus.com [109.150.212.220])
 (Authenticated sender: mauzo)
 by isis.morrow.me.uk (Postfix) with ESMTPSA id 2C25C450CD;
 Thu, 17 Jan 2013 07:33:06 +0000 (UTC)
X-DKIM: OpenDKIM Filter v2.4.1 isis.morrow.me.uk 2C25C450CD
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=morrow.me.uk;
 s=dkim201101; t=1358407988;
 bh=uV16Y5BwsA2TdKDXn8OtrzuVjnEIbrR7FaRZDsY6aOM=;
 h=Date:From:To:Subject:Message-ID:References:MIME-Version:
 Content-Type:In-Reply-To;
 b=vjrZC++LUexNS9wzmwhzi2hM+TwXehce1n04QvQg3I1SJHJkxZG7hoa0xGw0V5a8X
 TYri0NehI+Wx3uOttoChaX7LyliCghXhGuaElYet60ii72BifBWJVQCuo1pUDom0L+
 E5MAaXsGSMcoSitFv1/hSYwDQj3snHFBZbq7x1fU=
X-Virus-Status: Clean
X-Virus-Scanned: clamav-milter 0.97.5 at isis.morrow.me.uk
Received: by anubis.morrow.me.uk (Postfix, from userid 5001)
 id BADA58A76; Thu, 17 Jan 2013 07:33:01 +0000 (GMT)
Date: Thu, 17 Jan 2013 07:33:01 +0000
From: Ben Morrow <ben@morrow.me.uk>
To: kpaasial@gmail.com, freebsd-stable@freebsd.org
Subject: Re: CLANG 3.2 breaks security/pam_ssh_agent_auth on stable/9
Message-ID: <20130117073301.GA39402@anubis.morrow.me.uk>
References: <CA+7WWSeOpuAv9PL2_G6Z1Q_SLv5xcTjcujiw6Rs8tdBsrLO7wQ@mail.gmail.com>
 <50F6D20A.6070306@FreeBSD.org>
 <CA+7WWSfE1bAr7GriRGAKBVpkiNE+tn-+d0cO3vpNPY-SWxfghg@mail.gmail.com>
 <20130117001116.GD29437@lor.one-eyed-alien.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CA+7WWSfo0jX_tJEZ8YyzLSnnfaUZ0+sFYtVHhh8d=x2dYa+VXg@mail.gmail.com>
X-Newsgroups: gmane.os.freebsd.stable
Organization: morrow.me.uk
User-Agent: Mutt/1.5.21 (2010-09-15)
X-BeenThere: freebsd-stable@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Production branch of FreeBSD source code <freebsd-stable.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-stable>,
 <mailto:freebsd-stable-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-stable>
List-Post: <mailto:freebsd-stable@freebsd.org>
List-Help: <mailto:freebsd-stable-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-stable>,
 <mailto:freebsd-stable-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 17 Jan 2013 07:33:09 -0000

Quoth Kimmo Paasiala <kpaasial@gmail.com>:
> 
> Doesn't the change to strnvis() break the ABI on FreeBSD 9.X? I
> thought you could always compile a binary on an earlier version of
> FreeBSD 9.X and trust it to work without recompiling on any later
> minor version of the same major version line.

No, it doesn't. No existing prototypes are changed, there are just a
number of *nvis* functions added to complement the existing ones that
didn't have length arguments. The only problem is that the port assumes
that if a system has strnvis, it has a prototype matching OpenBSD's,
which the new one doesn't.

Ben