From owner-svn-src-all@freebsd.org Mon Dec 19 09:40:12 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2A464C8661F; Mon, 19 Dec 2016 09:40:12 +0000 (UTC) (envelope-from rpokala@mac.com) Received: from mr11p00im-asmtp003.me.com (mr11p00im-asmtp003.me.com [17.110.69.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 0EC5012CD; Mon, 19 Dec 2016 09:40:12 +0000 (UTC) (envelope-from rpokala@mac.com) Received: from process-dkim-sign-daemon.mr11p00im-asmtp003.me.com by mr11p00im-asmtp003.me.com (Oracle Communications Messaging Server 7.0.5.38.0 64bit (built Feb 26 2016)) id <0OIF00300BWVNJ00@mr11p00im-asmtp003.me.com>; Mon, 19 Dec 2016 08:39:56 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mac.com; s=4d515a; t=1482136796; bh=MtVuqjl3AT7wgrtdIY0AEZjpCpyxf57iyFl24/W5b3k=; h=Date:Subject:From:To:Message-id:MIME-version:Content-type; b=lPs8JhtXLqRyuDUNwtV4d4AMN1H2KYOQX16lvlOas/R5Ejjdgrf97wF2T7tb0tLan nEudVgJq0+Mrhdt+P4t/gngjK0zYJbGFufD8TXdcvQ98dZtWL9YGQo12VvcAZU0WKV jK7ybFX+sDfPL+LxFN3Nx0wLhEnOOrcZnfa7537VfcE69ccdl5F2ZZAJr3yoixPkyZ cVYkVB6xEyqDHQw2a2F+cgv0PgGNUBiSoOYSHTnCzAhqGg56DZ9pgJm1kTLBcYRjGY YkBkt+bukYo9DUhwBo2QCJNGdn1fPWr7R9QqFUCGZCdEimCH26mEQDzar0Ca4d/elo /BMXcFUBolQ6g== Received: from [192.168.1.4] (c-67-188-225-23.hsd1.ca.comcast.net [67.188.225.23]) by mr11p00im-asmtp003.me.com (Oracle Communications Messaging Server 7.0.5.38.0 64bit (built Feb 26 2016)) with ESMTPSA id <0OIF007S6C2IUQ30@mr11p00im-asmtp003.me.com>; Mon, 19 Dec 2016 08:39:55 +0000 (GMT) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-12-19_06:,, signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 clxscore=1034 suspectscore=2 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1603290000 definitions=main-1612190140 User-Agent: Microsoft-MacOutlook/f.1d.0.161209 Date: Mon, 19 Dec 2016 00:39:54 -0800 Subject: Re: svn commit: r310171 - head/sys/sys From: Ravi Pokala Sender: "Pokala, Ravi" To: Sepherosa Ziehau , Dimitry Andric Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-id: <9BD5034F-55A6-48F6-A391-A0877FF49702@panasas.com> Thread-topic: svn commit: r310171 - head/sys/sys References: <201612161949.uBGJnMol059217@repo.freebsd.org> In-reply-to: MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 Content-transfer-encoding: 7bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Dec 2016 09:40:12 -0000 -----Original Message----- > From: on behalf of Sepherosa Ziehau > Date: 2016-12-18, Sunday at 23:02 > To: Dimitry Andric > Cc: , , > Subject: Re: svn commit: r310171 - head/sys/sys > > The following patch unbreaks the LINT builds on amd64 for me after this commit: > https://people.freebsd.org/~sephe/geom_sscanf.diff Wouldn't it be better to use the SCN macros? -Ravi (rpokala@) > Please review it. > > Thanks, > sephe > > > On Sat, Dec 17, 2016 at 3:49 AM, Dimitry Andric wrote: >> Author: dim >> Date: Fri Dec 16 19:49:22 2016 >> New Revision: 310171 >> URL: https://svnweb.freebsd.org/changeset/base/310171 >> >> Log: >> Add __scanflike attributes to the kernel's sscanf() and vsscanf() >> declarations. This should help to catch future mismatches between >> format strings and arguments. >> >> MFC after: 1 week >> >> Modified: >> head/sys/sys/systm.h >> >> Modified: head/sys/sys/systm.h >> ============================================================================== >> --- head/sys/sys/systm.h Fri Dec 16 19:09:57 2016 (r310170) >> +++ head/sys/sys/systm.h Fri Dec 16 19:49:22 2016 (r310171) >> @@ -227,8 +227,8 @@ int vsnprintf(char *, size_t, const char >> int vsnrprintf(char *, size_t, int, const char *, __va_list) __printflike(4, 0); >> int vsprintf(char *buf, const char *, __va_list) __printflike(2, 0); >> int ttyprintf(struct tty *, const char *, ...) __printflike(2, 3); >> -int sscanf(const char *, char const *, ...) __nonnull(1) __nonnull(2); >> -int vsscanf(const char *, char const *, __va_list) __nonnull(1) __nonnull(2); >> +int sscanf(const char *, char const *, ...) __nonnull(1) __nonnull(2) __scanflike(2, 3); >> +int vsscanf(const char *, char const *, __va_list) __nonnull(1) __nonnull(2) __scanflike(2, 0); >> long strtol(const char *, char **, int) __nonnull(1); >> u_long strtoul(const char *, char **, int) __nonnull(1); >> quad_t strtoq(const char *, char **, int) __nonnull(1); >> _______________________________________________ >> svn-src-all@freebsd.org mailing list >> https://lists.freebsd.org/mailman/listinfo/svn-src-all >> To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org" > > -- > Tomorrow Will Never Die