From owner-cvs-all@FreeBSD.ORG Mon Jun 4 09:06:36 2007 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id C4D9616A46B; Mon, 4 Jun 2007 09:06:36 +0000 (UTC) (envelope-from brian@FreeBSD.org) Received: from storm.uk.FreeBSD.org (storm.uk.FreeBSD.org [194.242.157.42]) by mx1.freebsd.org (Postfix) with ESMTP id 63CF013C457; Mon, 4 Jun 2007 09:06:36 +0000 (UTC) (envelope-from brian@FreeBSD.org) Received: from store.lan.Awfulhak.org (store.lan.Awfulhak.org [172.16.0.35]) by storm.uk.FreeBSD.org (8.14.1/8.14.1) with ESMTP id l5496Yt4024160; Mon, 4 Jun 2007 10:06:34 +0100 (BST) (envelope-from brian@FreeBSD.org) Received: from store.lan.Awfulhak.org (localhost.localdomain [127.0.0.1]) by localhost (Postfix) with SMTP id CF7351957C6D; Mon, 4 Jun 2007 09:06:30 +0000 (GMT) Received: from gw.Awfulhak.org (gw.lan.Awfulhak.org [172.16.0.1]) by store.lan.Awfulhak.org (Postfix) with ESMTP id B03171957C61; Mon, 4 Jun 2007 09:06:24 +0000 (GMT) Received: from dev.lan.Awfulhak.org (brian@dev.lan.Awfulhak.org [172.16.0.5]) by gw.Awfulhak.org (8.14.1/8.14.1) with ESMTP id l5496OGZ011150; Mon, 4 Jun 2007 02:06:24 -0700 (PDT) (envelope-from brian@FreeBSD.org) Date: Mon, 4 Jun 2007 02:06:23 -0700 From: Brian Somers To: David Malone Message-ID: <20070604020623.49c95405@dev.lan.Awfulhak.org> In-Reply-To: <20070604084912.GA20502@walton.maths.tcd.ie> References: <200706040833.l548XIVm021432@repoman.freebsd.org> <20070604084912.GA20502@walton.maths.tcd.ie> X-Mailer: Claws Mail 2.9.2 (GTK+ 2.10.12; i386-portbld-freebsd7.0) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/speaker spkr.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Jun 2007 09:06:36 -0000 On Mon, 4 Jun 2007 09:49:12 +0100 David Malone wrote: > On Mon, Jun 04, 2007 at 08:33:18AM +0000, Brian Somers wrote: > > brian 2007-06-04 08:33:18 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/dev/speaker spkr.c > > Log: > > Speaker durations are specified in 1/100ths of a second according to > > spkr(4). > > I wasn't sure that the patch in the PR was completly correct, because > the tone and reset functions seem to be called from a few places, > some of which already factor in hz (playtone() does calculations > with "whole" which factors in hz) and some of which don't (spkrioctl, > which the PR referrs to). > > David. You're probably right - changing hz to '100' where 'whole' is set may be required. I'm just looking at testing some tempo and playtone() settings now... BRB. -- Brian Somers Don't _EVER_ lose your sense of humour !