Date: Mon, 4 Jun 2007 02:06:23 -0700 From: Brian Somers <brian@FreeBSD.org> To: David Malone <dwmalone@maths.tcd.ie> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/speaker spkr.c Message-ID: <20070604020623.49c95405@dev.lan.Awfulhak.org> In-Reply-To: <20070604084912.GA20502@walton.maths.tcd.ie> References: <200706040833.l548XIVm021432@repoman.freebsd.org> <20070604084912.GA20502@walton.maths.tcd.ie>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 4 Jun 2007 09:49:12 +0100 David Malone <dwmalone@maths.tcd.ie> wrote: > On Mon, Jun 04, 2007 at 08:33:18AM +0000, Brian Somers wrote: > > brian 2007-06-04 08:33:18 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/dev/speaker spkr.c > > Log: > > Speaker durations are specified in 1/100ths of a second according to > > spkr(4). > > I wasn't sure that the patch in the PR was completly correct, because > the tone and reset functions seem to be called from a few places, > some of which already factor in hz (playtone() does calculations > with "whole" which factors in hz) and some of which don't (spkrioctl, > which the PR referrs to). > > David. You're probably right - changing hz to '100' where 'whole' is set may be required. I'm just looking at testing some tempo and playtone() settings now... BRB. -- Brian Somers <brian@Awfulhak.org> Don't _EVER_ lose your sense of humour ! <brian@FreeBSD.org>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070604020623.49c95405>