From owner-freebsd-net  Tue Jan 14  1:32:39 2003
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 4994F37B401; Tue, 14 Jan 2003 01:32:38 -0800 (PST)
Received: from mail.imp.ch (mail.imp.ch [157.161.1.2])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id B843443EB2; Tue, 14 Jan 2003 01:32:36 -0800 (PST)
	(envelope-from mb@imp.ch)
Received: from levais.imp.ch (levais.imp.ch [157.161.4.66])
	by mail.imp.ch (8.12.6/8.12.3) with ESMTP id h0E9WUae057911;
	Tue, 14 Jan 2003 10:32:30 +0100 (CET)
	(envelope-from Martin.Blapp@imp.ch)
Date: Tue, 14 Jan 2003 10:32:36 +0100 (CET)
From: Martin Blapp <mb@imp.ch>
To: Thomas Moestl <tmoestl@gmx.net>
Cc: current@freebsd.org, "" <net@freebsd.org>
Subject: Re: PANIC in tcp_syncache.c sonewconn() line 562
In-Reply-To: <20030113215318.GA278@crow.dom2ip.de>
Message-ID: <20030114100620.W76016@levais.imp.ch>
References: <20030113173957.T73725@levais.imp.ch> <20030113215318.GA278@crow.dom2ip.de>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-freebsd-net@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-net.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-net>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-net>
X-Loop: FreeBSD.org


Hi Thomas,

>  	s = splnet();
> +	if (so->so_state & (SS_ISCONNECTED | SS_ISCONNECTING)) {
> +		splx(s);
> +		return (EINVAL);
> +	}
>  	error = (*so->so_proto->pr_usrreqs->pru_listen)(so, td);
>  	if (error) {
>  		splx(s);
>

Can you commit this ? The fix looks appropriate, but the manpage should
also be changed to reflect the change.

ERRORS
     Listen() will fail if:

     [EBADF]            The argument s is not a valid descriptor.
     [ENOTSOCK]         The argument s is not a socket.
     [EOPNOTSUPP]       The socket is not of a type that
			supports the operation listen().
     [EINVAL]		Listen() has been already called on the socket.

Any objections from others ?

Martin

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-net" in the body of the message