From owner-freebsd-toolchain@freebsd.org Thu Jun 9 07:12:43 2016 Return-Path: Delivered-To: freebsd-toolchain@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D4CA8AC8151 for ; Thu, 9 Jun 2016 07:12:43 +0000 (UTC) (envelope-from tijl@freebsd.org) Received: from mailrelay111.isp.belgacom.be (mailrelay111.isp.belgacom.be [195.238.20.138]) (using TLSv1.2 with cipher RC4-SHA (128/128 bits)) (Client CN "relay.skynet.be", Issuer "GlobalSign Organization Validation CA - SHA256 - G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 254621B11; Thu, 9 Jun 2016 07:12:41 +0000 (UTC) (envelope-from tijl@freebsd.org) X-Belgacom-Dynamic: yes X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A2BcDQAnFllX/4VasVtdgz5JDW4PuxSBehcNgjyDMwKBRDkUAQEBAQEBAWUnQQEBAQIBCgKDcwEBBAECNxwYCxALGAklDxkRHgYTiDMKvX8BAQEBAQEBAwEBAQEBASGKdIoaBZhShgOFNIJlcIFRjGhGjx0eNoIHHIFNOjIBAYNmgU+CI4IuAQEB Received: from 133.90-177-91.adsl-dyn.isp.belgacom.be (HELO kalimero.tijl.coosemans.org) ([91.177.90.133]) by relay.skynet.be with ESMTP; 09 Jun 2016 09:11:28 +0200 Received: from kalimero.tijl.coosemans.org (kalimero.tijl.coosemans.org [127.0.0.1]) by kalimero.tijl.coosemans.org (8.15.2/8.15.2) with ESMTP id u597BRW4001062; Thu, 9 Jun 2016 09:11:28 +0200 (CEST) (envelope-from tijl@FreeBSD.org) Date: Thu, 9 Jun 2016 09:11:27 +0200 From: Tijl Coosemans To: Jung-uk Kim Cc: Dimitry Andric , FreeBSD Toolchain , Gerald Pfeifer , Andreas Tobler , Baptiste Daroussin Subject: Re: Duplicate OPT_ entries in gcc/options.h Message-ID: <20160609091127.4795b484@kalimero.tijl.coosemans.org> In-Reply-To: <65f5f485-3ca8-4b22-7087-8793934f470d@FreeBSD.org> References: <75411813-0C9B-4CEF-BEE4-8B26DD8346F7@FreeBSD.org> <0610816e-2675-1abf-a4ee-274807317932@FreeBSD.org> <5A8D0A1F-6EA3-4DF2-82A2-EC1309C33E1E@FreeBSD.org> <823B7E6C-4B47-401F-A254-C88825AE5562@FreeBSD.org> <65f5f485-3ca8-4b22-7087-8793934f470d@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Jun 2016 07:12:43 -0000 On Wed, 8 Jun 2016 19:21:16 -0400 Jung-uk Kim wrote: > On 06/ 8/16 07:09 PM, Dimitry Andric wrote: >> On 09 Jun 2016, at 00:30, Jung-uk Kim wrote: >>> On 06/ 8/16 06:16 PM, Dimitry Andric wrote: >>>> On 08 Jun 2016, at 23:54, Jung-uk Kim wrote: >>>>> On 06/ 8/16 05:15 PM, Dimitry Andric wrote: >>>>>> On 08 Jun 2016, at 21:11, Gerald Pfeifer wrote: >>>>>>> I got a user report, and could reproduce this, that building >>>>>>> GCC (lang/gcc, but also current HEAD, so probably pretty much >>>>>>> any version) with FreeBSD 11 and LANG = en_US.UTF-8 we get >>>>>>> conflicting entires in $BUILDDIR/gcc/options.h such as >>>> ... >>>>>> Note that GNU awk does *not* produce a different optionlist file when >>>>>> used with either LANG=C or LANG=en_US.UTF-8. >>>> ... >>>>>> So I am assuming that the ARRAY[j-1] > ARRAY[j] comparison works >>>>>> differently in our awk, depending on the LANG settings. No idea when >>>>>> that changed, though, if it changed at all... >>>>> >>>>> This behaviour is known for very long time: >>>>> >>>>> https://svnweb.freebsd.org/changeset/base/173731 >>>>> >>>>> and it is not our fault: >>>>> >>>>> https://www.gnu.org/software/gawk/manual/html_node/POSIX-String-Comparison.html >>>> >>>> >>>> Indeed, so the real question is: why does this only started coming up >>>> now, if it is known since 2007? I have been building gcc ports for >>>> ages, and never ran into this problem, but I also have never actively >>>> used a persistent LANG environment variable, let alone with UTF-8 in it. >>>> >>>> Is this because more people started using UTF-8 recently? >>> >>> We are doing more correct collation now: >>> >>> https://svnweb.freebsd.org/changeset/base/290494 >> >> Indeed. This problem has come up before on the ports mailing list, >> almost immediately after that commit: >> >> https://lists.freebsd.org/pipermail/freebsd-ports/2015-November/101034.html >> >> Apparently some proposals were made to set LANG and LC_ALL to C globally >> for port builds, but it was never implemented? > > tijl proposed it but never implemented because of difficulties to > exp-run the change, it seems. > > http://docs.freebsd.org/cgi/mid.cgi?20151127145552.GA19655 There are over 300 files in the ports tree that match "[[:<:]]LANG[[:>:]]". I just don't have the time to go over all of them.