Date: Mon, 14 Jul 2014 16:49:54 -0400 From: Allan Jude <allanjude@freebsd.org> To: dteske@FreeBSD.org, freebsd-rc@freebsd.org Cc: 'Michael Dexter' <editor@callfortesting.org> Subject: Re: Bug 191869 - tmux(1) refuses to start via service(8) Message-ID: <53C44272.1070905@freebsd.org> In-Reply-To: <017a01cf9fa4$568196e0$0384c4a0$@FreeBSD.org> References: <017a01cf9fa4$568196e0$0384c4a0$@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On 2014-07-14 16:43, dteske@FreeBSD.org wrote: > Hi -rc, > > I'd like to get a review on a proposed patch to service(8). > > I've filed BUG #191869: > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=191869 > > Proposed commit/message below: > > Fix an issue with service(8) where utilities such as screen(1) and tmux(1) > would behave differently when utilizing rc-script was invoked manually vs. > service(8). The issue being that these utilities require the TERM environ > variable to be set and service(8) was not passing it down. > > Reported by: Michael Dexter <editor@callfortesting.org> > Reviewed by: <your name here> > MFC after: 3 days > X-MFC-to: stable/10, stable/9 > --This line, and those below, will be ignored-- > > M service/service.sh > > <see attached patch.txt> > This fix works for me. Solves the problem with my rc script that starts puppetdb in screen so I can reattach to the console in the future. I don't think it should cause any problem with the regular scripts as they startup, since TERM will be set to a reasonable default (cons25) -- Allan Jude [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (MingW32) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJTxEJ1AAoJEJrBFpNRJZKfo20P/0Y7W5sKOdrvuP6roETt6OS9 GDwSGO0M+Le/SM1P2sCQsCRJ/WNG39mA8KbojbpFQrjHkWKtHz6Z5xCz+yVk1ZJu Rmm34+vbZkbZSh5h0b08lH//wmwY//+dHbUwfUUAI1ZjRm2CTHHylXNPMTQ6bGn5 n1DQzhPrT+K7o5dPqas4EJX7NtBIawZ2w7tA3XuyhVac7RquFy/HwxvsGuQfF9ke c5Zti1pFnwiuyFhGqUS3oUun09s+5eK1jCz6ocGDnJe1cTqhPVW+qsceq7MHaN7N 3heG1wxIeOUjS+dTew1lIGaUfOnr9WxhdxR7FMFw26wW/kVCqvDbYVTcXFNG7y6n w39nXm3HJ9xtGJtVLCWQjDDCV6LfxyIzTuGXj87nR33StaDa8bpAy9GyEuGjsN0t 39jf+lJq9V3pUPwR7QaBALrcjF2aIZmaovGFVEThaWx02z7a8V0QzYFJLsu03Dc+ 5TCIoRI/V7ZC1e1RqV1/tQXqzO2QMAHsf75wIYeNyDcBIpCwGMv70bzfUVlo4ljO 5xpW+Gd0AztB3cO0UQpVbe7MemER+iSWgrrsa9cU9WA+nUz1zArAgJerN9UDRUnM qXj/JGA069tiJ3UOvyfGZp2F3w22dcXeK61sDJkSKgVJTvqDXgCS7TN+p4Ag6qeO Anyc4u4Z6t5FcgDjk9WI =f6QA -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?53C44272.1070905>