From nobody Sat Jun 18 11:07:51 2022 X-Original-To: fs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 2528F839025 for ; Sat, 18 Jun 2022 11:07:53 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4LQCn4727Gz4rfY for ; Sat, 18 Jun 2022 11:07:52 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id D18C11360D for ; Sat, 18 Jun 2022 11:07:52 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 25IB7q6I059369 for ; Sat, 18 Jun 2022 11:07:52 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 25IB7qLD059368 for fs@FreeBSD.org; Sat, 18 Jun 2022 11:07:52 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 165392] [ufs] [patch] Multiple mkdir/rmdir fails with errno 31 Date: Sat, 18 Jun 2022 11:07:51 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 9.0-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: kib@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: Normal X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Filesystems List-Archive: https://lists.freebsd.org/archives/freebsd-fs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-fs@freebsd.org MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1655550473; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OmNlUDn+3yimhvSQHBLn7amIEpOrnBFWYWcB93RftMs=; b=SjuVMLiKpWEv7nohk4TSsZKEezJI9qliEoYxZTSJo5QWheCizwAsGgTiKRk+NbFkb43CDL d1ov4LaLDJAn+UYleFfCMzaExs0+AUJvHuL7mb9VNLwRBDbwwIZ/sLItdu1d/m1fxthck7 +jfCUMjADsrbPr6jc59ljZbIJsY8z49M03JUWBaG8fcdKwgXHl9YDz5iOKTQJZp6CSe14a tIWYLeNr7rZanOE7yBKgLjKHYE7hK4xmrI+qF5ZSoobqXkTN1kUhWo5i+Ryigsdpb59UuH ElpXQHT3Rxk/qibTnKlVu2rdbJuugR3mDT1afUeH5rb5lq25gTd+4oky/qrULw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1655550473; a=rsa-sha256; cv=none; b=KruZdlKFJUjkbw79m9Nhb3ZPcGEEElQlbO8aCaP24FYAdCToFXYtWD3vVPR2vRtsYlfLh5 l+xk1TOB1GuR/w98bTcepBKUJxYmUz9XwUhhUN9XyGZ0KdQgRKJawIGS/NjmKW7X80yeZy BllUo2cCoztwUybTBJjb0gQHIcg2kdsjvKgyja2X6mmoHA9m/dnrVgRom/3KyNAPPr9n6u JSP3C17w24TfRikcu3xzpR2/nOAjvAUwc4OWoZo9uEwafp1W2pvMzG278n0KHkIHmohx1l 4/0ARMIVWdVJsf7qZzABDU9TrBxk/7fI66FBZBb66mT6av/HtxhfHG4PMHPKYA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D165392 Konstantin Belousov changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kib@FreeBSD.org, | |mckusick@FreeBSD.org, | |pho@FreeBSD.org --- Comment #12 from Konstantin Belousov --- I do not think it is enough to fsync() only the directory, as jh' patch cleanly illustrates. What it does is significant portion of VFS_SYNC() anyway, so it is cleaner to just do VFS_SYNC() and pay the cost of syncing data even if not strictly necessary. OTOH it is not safe to do any of that stuff while then vnode is locked. We recently got a way to correctly restart this kind of VOPs if they need to relock the directory, which implies the need to do re-lookup of the entr= y. I put the patch at https://reviews.freebsd.org/D35514 to handle just mkdir() for now. Other syscalls like link() and rename would need similar treatment if my patch works. --=20 You are receiving this mail because: You are the assignee for the bug.=