From owner-svn-src-all@FreeBSD.ORG  Mon Apr 20 10:37:54 2009
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 765D1106567E;
	Mon, 20 Apr 2009 10:37:54 +0000 (UTC)
	(envelope-from rwatson@FreeBSD.org)
Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42])
	by mx1.freebsd.org (Postfix) with ESMTP id 4EBE78FC08;
	Mon, 20 Apr 2009 10:37:54 +0000 (UTC)
	(envelope-from rwatson@FreeBSD.org)
Received: from fledge.watson.org (fledge.watson.org [65.122.17.41])
	by cyrus.watson.org (Postfix) with ESMTPS id E015846B0C;
	Mon, 20 Apr 2009 06:37:53 -0400 (EDT)
Date: Mon, 20 Apr 2009 11:37:53 +0100 (BST)
From: Robert Watson <rwatson@FreeBSD.org>
X-X-Sender: robert@fledge.watson.org
To: Bruce Evans <brde@optusnet.com.au>
In-Reply-To: <20090420171843.A58020@delplex.bde.org>
Message-ID: <alpine.BSF.2.00.0904201135470.71062@fledge.watson.org>
References: <200904192303.n3JN3v9w023289@svn.freebsd.org>
	<20090420171843.A58020@delplex.bde.org>
User-Agent: Alpine 2.00 (BSF 1167 2008-08-23)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org,
	src-committers@FreeBSD.org
Subject: Re: svn commit: r191292 - head/libexec/rtld-elf
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 20 Apr 2009 10:37:55 -0000

On Mon, 20 Apr 2009, Bruce Evans wrote:

>>  Explicitly include machine/param.h for CACHE_LINE_SIZE.
>>
>>  MFC after:	2 weeks
>> 
>> Modified:
>>  head/libexec/rtld-elf/rtld_lock.c
>
> It is a style bug (unwarranted chumminess with the implementation) to 
> include (or otherwise refer to) machine/param.h directly in *.c.  This is 
> only the 5th instance of this style bug in all of /usr/src.  The previous 
> ones are:

I think rtld would count as part of "the implementation" from most 
perspectives, but I agree, and have made the change :-).

Robert N M Watson
Computer Laboratory
University of Cambridge