Date: Sun, 1 Feb 2009 01:41:34 +0100 (CET) From: Gerald Pfeifer <gerald@FreeBSD.org> To: FreeBSD-gnats-submit@FreeBSD.org Subject: ports/131235: portlint: warn about COMMENT?= like we do for others Message-ID: <200902010041.n110fYC6096548@sputnik1.dbai.tuwien.ac.at> Resent-Message-ID: <200902010050.n110o2ZN079732@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 131235
>Category: ports
>Synopsis: portlint: warn about COMMENT?= like we do for others
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Sun Feb 01 00:50:01 UTC 2009
>Closed-Date:
>Last-Modified:
>Originator: Gerald Pfeifer
>Release: FreeBSD 7.1-RELEASE i386
>Organization:
>Environment:
System: FreeBSD sputnik1.dbai.tuwien.ac.at 7.1-RELEASE FreeBSD 7.1-RELEASE #0: Thu Jan 1 14:37:25 UTC 2009 root@logan.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC i386
>Description:
In case of COMMENT and other field we already warn that ?= only
should be used for master ports; we missed to do so for the
MAINTAINER field.
>How-To-Repeat:
>Fix:
Suggested patch below, tested against lang/gcc34 before adjusting
it.
--- /usr/local/bin/portlint 2009-01-31 12:51:17.000000000 +0100
+++ portlint 2009-02-01 01:29:40.723187000 +0100
@@ -2523,8 +2523,12 @@
));
$tmp = "\n" . $tmp;
- if ($tmp =~ /\nMAINTAINER\??=([^\n]+)/) {
- my $addr = $1;
+ if ($tmp =~ /\nMAINTAINER(\?)?=([^\n]+)/) {
+ if ($1 ne '') {
+ &perror("WARN", $file, -1, "unless this is a master port, MAINTAINER has to be set by \"=\", ".
+ "not by \"$1=\".") unless ($masterport);
+ }
+ my $addr = $2;
$addr =~ s/^\s*//;
$addr =~ s/\s*$//;
if ($addr =~ /[\s,<>()]/) {
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200902010041.n110fYC6096548>