From owner-freebsd-stable@FreeBSD.ORG Fri Mar 28 21:35:27 2014 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id E94A0746; Fri, 28 Mar 2014 21:35:26 +0000 (UTC) Received: from tensor.andric.com (tensor.andric.com [87.251.56.140]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client CN "tensor.andric.com", Issuer "CAcert Class 3 Root" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 6EB517B3; Fri, 28 Mar 2014 21:35:26 +0000 (UTC) Received: from [IPv6:2001:7b8:3a7::3921:ab0d:c24c:508b] (unknown [IPv6:2001:7b8:3a7:0:3921:ab0d:c24c:508b]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by tensor.andric.com (Postfix) with ESMTPSA id BCD305C44; Fri, 28 Mar 2014 22:35:21 +0100 (CET) Content-Type: multipart/signed; boundary="Apple-Mail=_41C9BB14-E7EC-48BD-B8D0-71BFCD33D4CC"; protocol="application/pgp-signature"; micalg=pgp-sha1 Mime-Version: 1.0 (Mac OS X Mail 7.2 \(1874\)) Subject: Re: HEADS UP: merged llvm/clang 3.4 From: Dimitry Andric In-Reply-To: <5335E715.3090603@FreeBSD.org> Date: Fri, 28 Mar 2014 22:35:09 +0100 Message-Id: References: <20140328165121.13797.qmail@mailgate.gta.com> <6F2AEDEC-4173-45B0-9C21-1D80E33660F6@FreeBSD.org> <1396029772.81853.150.camel@revolution.hippie.lan> <5335E715.3090603@FreeBSD.org> To: Jung-uk Kim X-Mailer: Apple Mail (2.1874) Cc: Craig Rodrigues , Larry Baird , FreeBSD stable , Ian Lepore X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Mar 2014 21:35:27 -0000 --Apple-Mail=_41C9BB14-E7EC-48BD-B8D0-71BFCD33D4CC Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=iso-8859-1 On 28 Mar 2014, at 22:18, Jung-uk Kim wrote: > Signed PGP part > On 2014-03-28 16:25:42 -0400, Craig Rodrigues wrote: > > On Fri, Mar 28, 2014 at 11:11 AM, Dimitry Andric > > wrote: > >> > >> You need to rebuild the system anyway, if you want debug > >> information, so nothing changed? If you insist on wanting to use > >> the crummy gdb in base, which should have been axed years ago, > >> then just use DEBUG_FLAGS=-gdwarf-2, otherwise use ports gdb, > >> which any sensible person should do. > >> > >> -Dimitry > >> > > > > This kind of thing is OK for HEAD, but to me seems like something > > which is not OK for a stable branch. > > > > Before your change: "cc -g" from base + gdb in base = can debug > > After your change: "cc -g" from base + gdb in base = cannot > > debug > > > > Is it possible to modify clang in base, so that on the stable > > branches, "cc -g" will output dwarf-2 instead of dwarf-4 by > > default? > > > > I understand that installing gdb from ports, changing compiler > > flags from -g to -gdwarf-2 in Makefiles, or switching to compiling > > with gcc are all reasonable workarounds, but this seems a bit like > > POLA for a stable branch. > > Yeah, it is really unpleasant. > > Maybe we should do something like this for stable/9 and stable/10 > branches (not tested). > > --- contrib/llvm/tools/clang/lib/Driver/Tools.cpp > +++ contrib/llvm/tools/clang/lib/Driver/Tools.cpp > @@ -2628,8 +2628,9 @@ void Clang::ConstructJob(Compilation &C, const Job > CmdArgs.push_back("-gdwarf-4"); > else if (!A->getOption().matches(options::OPT_g0) && > !A->getOption().matches(options::OPT_ggdb0)) { > - // Default is dwarf-2 for darwin. > - if (getToolChain().getTriple().isOSDarwin()) > + // Default is dwarf-2 for Darwin and FreeBSD. > + if (getToolChain().getTriple().isOSDarwin() || > + getToolChain().getTriple().getOS() == llvm::Triple::FreeBSD) > CmdArgs.push_back("-gdwarf-2"); > else > CmdArgs.push_back("-g"); I'm now testing something similar, which also tests the FreeBSD version, so it can be applied to head and then MFC'd. I will commit it soon. -Dimitry --Apple-Mail=_41C9BB14-E7EC-48BD-B8D0-71BFCD33D4CC Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.22 (Darwin) iEYEARECAAYFAlM16xcACgkQsF6jCi4glqPNoACgke49f450300v+/0hUB9IYeGp uCIAoMOyhrkyvZzZSZvf7oxxIA8l2Nnv =7rcj -----END PGP SIGNATURE----- --Apple-Mail=_41C9BB14-E7EC-48BD-B8D0-71BFCD33D4CC--