From owner-svn-src-all@freebsd.org Sun Feb 5 01:21:05 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5A650CD0247 for ; Sun, 5 Feb 2017 01:21:05 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-io0-x241.google.com (mail-io0-x241.google.com [IPv6:2607:f8b0:4001:c06::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 265321CF9 for ; Sun, 5 Feb 2017 01:21:05 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-io0-x241.google.com with SMTP id m98so5933806iod.2 for ; Sat, 04 Feb 2017 17:21:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=dHZFfgGmi7/Mein23dg3tC9cmBqROkHsvD68kswj900=; b=i/g98ht8vwvVpVeqae1wwNSYVdDxIxUBUDJKMIfEi0S8XKI6+J2HzGTtGF5M2C+O6E /628WOORBF0ciSSIgJMKwTTOqoVywiLAhLSpfvSilxTIsOJzdOr0V8iiE+xwG5wQpuZ6 4+c3Yp5xiV4m/YO7URrrKL8fQwPLrChTNpW2Un1wQ4uXoE6kjrHYEbxje1dO9OmeXALI n3qFrWVsn7Y9bhXFmKF0k5z3m5IBvxf8yWnVNMk2AvzXXHJzN2MCmYp+dawf3JoeO95v MYtnbg4IQ6ZXeQsK3KhRQ+V0yiX7OM6BdZUCfZ02IH120eePH6+5JsA+OO2zOaX/a5Tt gSbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=dHZFfgGmi7/Mein23dg3tC9cmBqROkHsvD68kswj900=; b=ll/HzqjiVqA8IEmjU50TiCsV/O3lnV3Cz4Mpv0ALUJabzR7XV2Lc9JC4KtLK33+6c4 ENPE2o55D+ewmXnDaumi8nHLL8svPWC//2A6WhBPitiZt83Ju6+55UGbbdSGHL/B/UbZ CtOKtKnyFxY8HPgIQtqo3OmWmlb+5OUNzoBuNCKFt/jHomoduuKLQS1Vi0sdbBUT8Y4l a6ylATgfIjdCDoHfD2DwLxVVKPuc9A/FzpbnrD+EQlea1RJjWOj5LoLhOa6/c0+aTIaG NiKJeTedHDT8FbyZZ0KfIBLRhlsrkpqqQB07FL5xKMFQxI3Zgr2MV2UjDGT8RO1GS5Np cemA== X-Gm-Message-State: AMke39lysID5/Ng8Xjea3rnHbkdl5UTphuz9H1cpKmPzNtvb3P3spB88k1rHl8N7SUJYrZNx1UVV73J5zpWEiw== X-Received: by 10.107.139.131 with SMTP id n125mr3014708iod.166.1486257664237; Sat, 04 Feb 2017 17:21:04 -0800 (PST) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 10.79.145.217 with HTTP; Sat, 4 Feb 2017 17:21:02 -0800 (PST) X-Originating-IP: [69.53.245.200] In-Reply-To: <201702050116.v151Gtj1060849@slippy.cwsent.com> References: <201702040553.v145r1wB002775@repo.freebsd.org> <201702050116.v151Gtj1060849@slippy.cwsent.com> From: Warner Losh Date: Sat, 4 Feb 2017 18:21:02 -0700 X-Google-Sender-Auth: aG4UViT5uFIHT9Icc8DAx5AtU4Q Message-ID: Subject: Re: svn commit: r313191 - head/sbin/nvmecontrol To: Cy Schubert Cc: Warner Losh , src-committers , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 05 Feb 2017 01:21:05 -0000 Thanks! Fixed in r313259. Warner On Sat, Feb 4, 2017 at 6:16 PM, Cy Schubert wrote: > In message <201702040553.v145r1wB002775@repo.freebsd.org>, Warner Losh > writes: >> Author: imp >> Date: Sat Feb 4 05:53:00 2017 >> New Revision: 313191 >> URL: https://svnweb.freebsd.org/changeset/base/313191 >> >> Log: >> Implement 5 wdc-specific nvme control options for their HGST drives: >> wdc cap-diag Capture diagnostic data from drive >> wdc drive-log Capture drive history data from drive >> wdc get-crash-dump Retrieve firmware crash dump from drive >> >> Added: >> head/sbin/nvmecontrol/wdc.c (contents, props changed) >> Modified: >> head/sbin/nvmecontrol/Makefile >> head/sbin/nvmecontrol/nvmecontrol.8 >> head/sbin/nvmecontrol/nvmecontrol.c >> head/sbin/nvmecontrol/nvmecontrol.h > [...] >> + while (len > 0) { >> + resid = len > NVME_MAX_XFER_SIZE ? NVME_MAX_XFER_SIZE : len; >> + wdc_get_data(fd, opcode, resid, offset, cmd, buf, resid); >> + if (write(fd2, buf, resid) != resid) > > Hi Warner, > > I'm seeing the following on i386. > > opt/src/svn-current/sbin/nvmecontrol/wdc.c:156:30: error: comparison of > integers of different signs: 'ssize_t' (aka 'int') and 'uint32_t' (aka > 'unsigned int') [-Werror,-Wsign-compare] > if (write(fd2, buf, resid) != resid) > ~~~~~~~~~~~~~~~~~~~~~~ ^ ~~~~~ > 1 error generated. > > amd64 builds okay. > >> + err(1, "write"); >> + offset += resid; >> + len -= resid; >> + } >> + free(buf); >> + close(fd2); > [...] > > > -- > Cheers, > Cy Schubert > FreeBSD UNIX: Web: http://www.FreeBSD.org > > The need of the many outweighs the greed of the few. > >