Date: Sat, 22 Feb 2020 18:24:13 +0000 From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 244319] vm.v_* sysctls should be read-only, make per-domain sysctls writable Message-ID: <bug-244319-227@https.bugs.freebsd.org/bugzilla/>
next in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D244319 Bug ID: 244319 Summary: vm.v_* sysctls should be read-only, make per-domain sysctls writable Product: Base System Version: CURRENT Hardware: Any OS: Any Status: New Severity: Affects Many People Priority: --- Component: kern Assignee: bugs@FreeBSD.org Reporter: alex_y_xu@yahoo.ca CC: jeff@FreeBSD.org after https://svnweb.freebsd.org/base/head/sys/vm/vm_pageout.c?r1=3D327954&r2=3D3= 28954 (https://reviews.freebsd.org/D14000), the various v_* targets were made domain-specific, and vm_cnt was made a sum of the individual domain metrics. however, it doesn't seem to consider that those sysctls are actually read-write, not read-only in vm_meter. the easy fix is to just make the top-level sysctls read-only, but I think that it would be better to make the per-domain sysctls also writable. the top-level sysctls can't be removed because vm/swap_pager.c checks vm_cnt.v_free_reserved, and cddl/contrib/opensolaris/uts/common/fs/zfs/arc.c checks vm_cnt.v_free_targe= t. I suspect that the swap accounting should actually be domain-aware though. anyways, you still need to update vm_cnt.v_free_reserved and vm_cnt.v_free_target, and at that point you might as well keep everything. I think VM_STATS_UINT(v_*) except v_*_count should probably be removed thou= gh, since they are not really "statistics", and sysctls for vmd_interrupt_free_= min and vmd_pageout_free_min should be added. I tried making a patch, but I couldn't figure out how to work SYSCTL_ADD_PR= OC. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-244319-227>