From owner-freebsd-current@FreeBSD.ORG Wed Feb 22 19:32:27 2006 Return-Path: X-Original-To: current@freebsd.org Delivered-To: freebsd-current@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 41B8216A420; Wed, 22 Feb 2006 19:32:27 +0000 (GMT) (envelope-from kris@obsecurity.org) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0025643D45; Wed, 22 Feb 2006 19:32:26 +0000 (GMT) (envelope-from kris@obsecurity.org) Received: from obsecurity.dyndns.org (elvis.mu.org [192.203.228.196]) by elvis.mu.org (Postfix) with ESMTP id CE12D1A3C1C; Wed, 22 Feb 2006 11:32:26 -0800 (PST) Received: by obsecurity.dyndns.org (Postfix, from userid 1000) id BA4DB517D5; Wed, 22 Feb 2006 14:32:25 -0500 (EST) Date: Wed, 22 Feb 2006 14:32:25 -0500 From: Kris Kennaway To: John Baldwin Message-ID: <20060222193225.GA38057@xor.obsecurity.org> References: <200602211047.06599.jhb@freebsd.org> <20060222023646.GA75290@xor.obsecurity.org> <200602221101.41027.jhb@freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="AqsLC8rIMeq19msA" Content-Disposition: inline In-Reply-To: <200602221101.41027.jhb@freebsd.org> User-Agent: Mutt/1.4.2.1i Cc: current@freebsd.org, Kris Kennaway Subject: Re: [PATCH] possible fix for the runtime going backwards warnings X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Feb 2006 19:32:27 -0000 --AqsLC8rIMeq19msA Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Feb 22, 2006 at 11:01:39AM -0500, John Baldwin wrote: > On Tuesday 21 February 2006 21:36, Kris Kennaway wrote: > > On Tue, Feb 21, 2006 at 10:47:04AM -0500, John Baldwin wrote: > > > The latest round of calcru() changes accidentally changed calccru() to > > > use the wrong rusage_ext structure (p->p_rux vs p->p_crux) when > > > calculating usage times for children. The patch fixes calccru() to u= se > > > p->p_crux again. It also moves the ruadd() in exit1() even later in = the > > > function so that it takes the dying thread's last time slice into > > > account. Please test it and let me know if it makes the messages go = away > > > (or if it makes things worse!) Thanks! > > > > > > http://www.FreeBSD.org/~jhb/patches/calccru.patch > > > > I think you committed this already, right? >=20 > Yes. >=20 > > I'm still getting calcru spam on the 3 SMP machines that I upgraded > > with fresh sources: >=20 > Is it more or less than before the patch? Also, what happens if you just= back=20 > out the kern_exit.c change? About the same. > The pagezero ones are truly odd. calcru() shouldn't be called for kthrea= ds=20 > very often (if at all). I wonder if your tickrate is changing out from u= nder=20 > you. Try editing sys/i386/i386/tsc.c and where it does 'set_cputicker(rd= tsc,=20 > tsc_freq, 1)' change the last parameter to '0' and see if they go away. OK. Kris --AqsLC8rIMeq19msA Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (FreeBSD) iD8DBQFD/LxJWry0BWjoQKURAii+AJ99Q/S5KeP7zJSMLQkOyDrlCWqUjACgmPFZ dz6zeh7thU7vhDZ+rCOQefU= =QPXI -----END PGP SIGNATURE----- --AqsLC8rIMeq19msA--