Date: Fri, 11 Dec 2009 00:54:12 +0300 From: pluknet <pluknet@gmail.com> To: Doug Barton <dougb@freebsd.org> Cc: freebsd-net@freebsd.org Subject: Re: ping6 and a do-not-fragment option Message-ID: <a31046fc0912101354g21afe649r278d0f70095af546@mail.gmail.com> In-Reply-To: <4B21576C.7030605@FreeBSD.org> References: <20091210190305.GT45152@gerbil.cluepon.net> <4B21576C.7030605@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--0015175cab14f647b9047a66d87b Content-Type: text/plain; charset=ISO-8859-1 2009/12/10 Doug Barton <dougb@freebsd.org>: > Richard A Steenbergen wrote: >> Hi, >> >> I just noticed, while trying to do a little debugging, that ping6 >> doesn't seem to have a way to specify "do not fragment" like ping does >> for IPv4. Obviously the way this is implemented has been changed, since >> there is no longer a DF-bit in IPv6, but it looks like there is already >> an IPV6_DONTFRAG setsockopt() available for exactly this purpose. It >> looks like IPV6_DONTFRAG got added at a later date (from RFC3542), >> perhaps after ping6 was initially written. >> >> It seems like the correct fix would be to add a cli option to ping6 >> (perhaps 'D', since it's available and matches the command in ping) to >> call this setsockopt() and implement a "do not fragment" option. >> > > Sounds good, we look forward to reviewing your patches. :) > Sure, there might be compatibility issues in between KAME or something else.. -- wbr, pluknet --0015175cab14f647b9047a66d87b Content-Type: application/octet-stream; name="ping6.nofrag.patch" Content-Disposition: attachment; filename="ping6.nofrag.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_g322csgi0 ZGlmZiAtdXJwTiBwaW5nNi5vcmlnL3Bpbmc2LjggcGluZzYvcGluZzYuOAotLS0gcGluZzYub3Jp Zy9waW5nNi44CTIwMDktMTItMTAgMjM6Mzg6MzcuMDAwMDAwMDAwICswMzAwCisrKyBwaW5nNi9w aW5nNi44CTIwMDktMTItMTEgMDA6MTg6MTcuMDAwMDAwMDAwICswMzAwCkBAIC00MCw5ICs0MCw5 IEBAIHBhY2tldHMgdG8gbmV0d29yayBob3N0cwogLlNoIFNZTk9QU0lTCiAuTm0KIC5cIiB3aXRo b3V0IGlwc2VjLCBvciBuZXcgaXBzZWMKLS5PcCBGbCBkZkhtbk5vcXJSdHZ3VworLk9wIEZsIERk Zkhtbk5vcXJSdHZ3VwogLlwiIG9sZCBpcHNlYwotLlwiIC5PcCBGbCBBZEVmbW5OcVJ0dndXCisu XCIgLk9wIEZsIEFEZEVmbW5OcVJ0dndXCiAuQmsgLXdvcmRzCiAuT3AgRmwgYSBBciBhZGRydHlw ZQogLkVrCkBAIC0xNDEsNiArMTQxLDggQEAgU3RvcCBhZnRlciBzZW5kaW5nCiAuQXIgY291bnQK IC5UbiBFQ0hPX1JFU1BPTlNFCiBwYWNrZXRzLgorLkl0IEZsIEQKK0Rpc2FibGUgSVB2NiBmcmFn bWVudGF0aW9uLgogLkl0IEZsIGQKIFNldCB0aGUKIC5EdiBTT19ERUJVRwpkaWZmIC11cnBOIHBp bmc2Lm9yaWcvcGluZzYuYyBwaW5nNi9waW5nNi5jCi0tLSBwaW5nNi5vcmlnL3Bpbmc2LmMJMjAw OS0xMi0xMCAyMzozODozNy4wMDAwMDAwMDAgKzAzMDAKKysrIHBpbmc2L3Bpbmc2LmMJMjAwOS0x Mi0xMSAwMDoyMDo0Ny4wMDAwMDAwMDAgKzAzMDAKQEAgLTE5MSw2ICsxOTEsNyBAQCBzdHJ1Y3Qg dHYzMiB7CiAjZGVmaW5lIEZfT05DRQkJMHgyMDAwMDAKICNkZWZpbmUgRl9BVURJQkxFCTB4NDAw MDAwCiAjZGVmaW5lIEZfTUlTU0VECTB4ODAwMDAwCisjZGVmaW5lIEZfRE9OVEZSQUcJMHgxMDAw MDAwCiAjZGVmaW5lIEZfTk9VU0VSREFUQQkoRl9OT0RFQUREUiB8IEZfRlFETiB8IEZfRlFETk9M RCB8IEZfU1VQVFlQRVMpCiB1X2ludCBvcHRpb25zOwogCkBAIC0zNDksNyArMzUwLDcgQEAgbWFp bihhcmdjLCBhcmd2KQogI2VuZGlmIC8qSVBTRUNfUE9MSUNZX0lQU0VDKi8KICNlbmRpZgogCXdo aWxlICgoY2ggPSBnZXRvcHQoYXJnYywgYXJndiwKLQkgICAgImE6YjpjOmRmSGc6aDpJOmk6bDpt bk5vcDpxclJTOnM6dHZ3VyIgQURET1BUUykpICE9IC0xKSB7CisJICAgICJhOmI6YzpEZGZIZzpo Okk6aTpsOm1uTm9wOnFyUlM6czp0dndXIiBBRERPUFRTKSkgIT0gLTEpIHsKICN1bmRlZiBBRERP UFRTCiAJCXN3aXRjaCAoY2gpIHsKIAkJY2FzZSAnYSc6CkBAIC00MTUsNiArNDE2LDkgQEAgbWFp bihhcmdjLCBhcmd2KQogCQkJCWVycngoMSwKIAkJCQkgICAgImlsbGVnYWwgbnVtYmVyIG9mIHBh Y2tldHMgLS0gJXMiLCBvcHRhcmcpOwogCQkJYnJlYWs7CisJCWNhc2UgJ0QnOgorCQkJb3B0aW9u cyB8PSBGX0RPTlRGUkFHOworCQkJYnJlYWs7CiAJCWNhc2UgJ2QnOgogCQkJb3B0aW9ucyB8PSBG X1NPX0RFQlVHOwogCQkJYnJlYWs7CkBAIC03NDMsOCArNzQ3LDEyIEBAIG1haW4oYXJnYywgYXJn dikKIAkJKigodV9pbnQzMl90ICopJm5vbmNlW2ldKSA9IGFyYzRyYW5kb20oKTsKICNlbmRpZgog CisJb3B0dmFsID0gMTsKKwlpZiAob3B0aW9ucyAmIEZfRE9OVEZSQUcpCisJCWlmIChzZXRzb2Nr b3B0KHMsIElQUFJPVE9fSVBWNiwgSVBWNl9ET05URlJBRywKKwkJICAgICZvcHR2YWwsIHNpemVv ZihvcHR2YWwpKSA9PSAtMSkKKwkJCWVycigxLCAiSVBWNl9ET05URlJBRyIpOwogCWhvbGQgPSAx OwotCiAJaWYgKG9wdGlvbnMgJiBGX1NPX0RFQlVHKQogCQkodm9pZClzZXRzb2Nrb3B0KHMsIFNP TF9TT0NLRVQsIFNPX0RFQlVHLCAoY2hhciAqKSZob2xkLAogCQkgICAgc2l6ZW9mKGhvbGQpKTsK QEAgLTI3ODAsNyArMjc4OCw3IEBAIHVzYWdlKCkKIAkgICAgIkEiCiAjZW5kaWYKIAkgICAgInVz YWdlOiBwaW5nNiBbLSIKLQkgICAgImQiCisJICAgICJEZCIKICNpZiBkZWZpbmVkKElQU0VDKSAm JiAhZGVmaW5lZChJUFNFQ19QT0xJQ1lfSVBTRUMpCiAJICAgICJFIgogI2VuZGlmCg== --0015175cab14f647b9047a66d87b--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?a31046fc0912101354g21afe649r278d0f70095af546>