From nobody Wed Jun 3 07:10:45 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gVf454fd3z6gBM3 for ; Wed, 03 Jun 2026 07:10:45 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gVf4537WCz3VXl for ; Wed, 03 Jun 2026 07:10:45 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1780470645; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=/1+yDUq1zgMgLdyURHSClyr0kYEBURX5TpuiSsPrl+Q=; b=q/wzD8K3ZnzG8PlLYvIhFkEE1BJv/5JRjypX2qJYj+yzMES2mkZgrN+Lyzx0g17lPenn81 BPZDG1qgwxarrkIIMESrJexfv8+xPOymM3v+GDlsfvi/AMi1pmDSACN84fq4SX1J2qOQhr /v/7jx4a4WPo6CYpWOQvvIEMixTT4TdbMl+ObB+8ALtKrE8NXEvkOwxnTYylsONQSUX/dZ 2aG8N7DFD8mh2f/pPpAkr9HyDi/pKBUncc83JjEK9Xi7cswv6Oc+UVagQYCWcw1Ac/J8nL J+tWCA9EBBi05UHW0IJRyZcc21HvLJA9G19ckaHcwwb/uhVyiMUg3BtO2U1cfw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1780470645; a=rsa-sha256; cv=none; b=MuyIP1HQUO3YNtsJNtG5Q4nk7QRqmdn6TSzu2M9tzOSUt/K2B7fqOrN5PuPxPAjQ7XSHyO S7zRRofii+I9R4WB/4jTwgvJNxtnLYvoYYdgN2ItBg5anPze2MdXYWcteId9M3snbqKoWH ktuI0xpJbL8yh/LrtiUw5nsjgD7QG/jREFusgW1INl2vJ7hP+43I5wpuTKPbO1nPSJ4GyZ 3TAZJiq8dswZmK8BUrvSdmAPScffAFnXQhsb4DEwMf6SXPtmyB1lGXGbGRgfUSJjQj78IC bX7zRSq2D6NcqLDiinZ/Ucosqpr1/RFbXBwk9WHT9N1sqP64XGd4AVj2w+HZ2w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1780470645; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=/1+yDUq1zgMgLdyURHSClyr0kYEBURX5TpuiSsPrl+Q=; b=LLP3SyosQtVlWTHpNaGgBUYRAryxu9aFPPOkw0E/AHuxC0Y+Zakcy3C24riT+khS6IAVyF 2frZIzJaG9zJBwIvPlvT1cvS7i2/P5xxbhwx05eqKy2HpD2cOUCDjQJFogLmKeKplJR1HW Np2UpJZ+n16BTYvcuhpXEWS87AkZ6y8XG1bfsJWX2m5ATv8BMchyCW94CV+N2mafbTj4+N kv0RxbAyhO2v0XYVB3K2u1asvUJJLTQa8ABqQCGXTEiffw/lut5ErfLMBo8zdioDZ4JKql tGBGUlRPpU8DjSrLxDnjrWJIjSwho0TY5jImubiHHTkLetd62pMlexPaGzPGMA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4gVf452fLNz11KH for ; Wed, 03 Jun 2026 07:10:45 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 332ab by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 03 Jun 2026 07:10:45 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Navdeep Parhar Subject: git: 4b6887e38638 - main - cxgbe(4): Do not read indirect INT_CAUSE registers directly List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: np X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 4b6887e3863881ff3be447c00fa2ae0c563550c5 Auto-Submitted: auto-generated Date: Wed, 03 Jun 2026 07:10:45 +0000 Message-Id: <6a1fd375.332ab.c3e63af@gitrepo.freebsd.org> The branch main has been updated by np: URL: https://cgit.FreeBSD.org/src/commit/?id=4b6887e3863881ff3be447c00fa2ae0c563550c5 commit 4b6887e3863881ff3be447c00fa2ae0c563550c5 Author: Navdeep Parhar AuthorDate: 2026-06-01 23:36:36 +0000 Commit: Navdeep Parhar CommitDate: 2026-06-03 06:36:34 +0000 cxgbe(4): Do not read indirect INT_CAUSE registers directly Some of the registers added in a172f9e5b3cf are not directly accessible and should be avoided. Fixes: a172f9e5b3cf cxgbe(4): Improvements to the slow interrupt handler MFC after: 1 week Sponsored by: Chelsio Communications --- sys/dev/cxgbe/common/t4_hw.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/sys/dev/cxgbe/common/t4_hw.c b/sys/dev/cxgbe/common/t4_hw.c index 41606201ad39..1386ae1767fd 100644 --- a/sys/dev/cxgbe/common/t4_hw.c +++ b/sys/dev/cxgbe/common/t4_hw.c @@ -6610,6 +6610,7 @@ static bool pmtx_intr_handler(struct adapter *adap, int arg, int flags) .details = NULL, .actions = pmtx_int_cause_actions, }; +#ifdef notyet static const struct intr_details pmtx_perr_cause_details[] = { { F_ICSPI_OVFL, "icspi FIFO Overflow" }, { F_OSPI_OVERFLOW3_TX, " OSPI overflow on channel 3 error." }, @@ -6641,6 +6642,7 @@ static bool pmtx_intr_handler(struct adapter *adap, int arg, int flags) .details = pmtx_perr_cause_details, .actions = NULL, }; +#endif bool fatal; if (chip_id(adap) >= CHELSIO_T7) @@ -6648,8 +6650,10 @@ static bool pmtx_intr_handler(struct adapter *adap, int arg, int flags) else pmtx_int_cause.details = pmtx_int_cause_fields; fatal = t4_handle_intr(adap, &pmtx_int_cause, 0, flags); +#ifdef notyet if (chip_id(adap) >= CHELSIO_T7) fatal |= t4_handle_intr(adap, &pmtx_perr_cause, 0, flags); +#endif clear_int_cause_reg(adap, &pmtx_int_cause, flags); return (fatal); @@ -6705,6 +6709,7 @@ static bool pmrx_intr_handler(struct adapter *adap, int arg, int flags) .details = NULL, .actions = NULL, }; +#ifdef notyet static const struct intr_details pm_rx_int_cause_2_details[] = { { F_CACHE_SRAM_ODD_CERR, "Cache Data Odd SRAM Correctable Error" }, { F_CACHE_SRAM_EVEN_CERR, "Cache Data Even SRAM Correctable Error" }, @@ -6766,13 +6771,16 @@ static bool pmrx_intr_handler(struct adapter *adap, int arg, int flags) .details = pm_rx_perr_cause_details, .actions = NULL, }; +#endif bool fatal; if (chip_id(adap) >= CHELSIO_T7) { pmrx_int_cause.details = t7_pmrx_int_cause_fields; fatal = t4_handle_intr(adap, &pmrx_int_cause, 0, flags); +#ifdef notyet fatal |= t4_handle_intr(adap, &pmrx_int_cause2, 0, flags); fatal |= t4_handle_intr(adap, &pmrx_perr_cause, 0, flags); +#endif } else { pmrx_int_cause.details = pmrx_int_cause_fields; fatal = t4_handle_intr(adap, &pmrx_int_cause, 0, flags);