From owner-cvs-ports@FreeBSD.ORG Mon Jan 9 23:02:17 2012 Return-Path: Delivered-To: cvs-ports@FreeBSD.org Received: from mx2.freebsd.org (mx2.freebsd.org [IPv6:2001:4f8:fff6::35]) by hub.freebsd.org (Postfix) with ESMTP id 2A7A61065691; Mon, 9 Jan 2012 23:02:17 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from 172-17-198-245.globalsuite.net (hub.freebsd.org [IPv6:2001:4f8:fff6::36]) by mx2.freebsd.org (Postfix) with ESMTP id 7E6FB151EF2; Mon, 9 Jan 2012 23:01:47 +0000 (UTC) Message-ID: <4F0B71DA.6000707@FreeBSD.org> Date: Mon, 09 Jan 2012 15:01:46 -0800 From: Doug Barton Organization: http://SupersetSolutions.com/ User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20111222 Thunderbird/9.0 MIME-Version: 1.0 To: Lars Balker Rasmussen References: <201201091459.q09ExWNN058008@repoman.freebsd.org> In-Reply-To: <201201091459.q09ExWNN058008@repoman.freebsd.org> X-Enigmail-Version: undefined OpenPGP: id=1A1ABC84 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: cvs-ports@FreeBSD.org, adamw@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/textproc/p5-ack Makefile pkg-plist X-BeenThere: cvs-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Jan 2012 23:02:17 -0000 Please don't add new dependencies based on things that exist, or don't exist in LOCALBASE. This causes unexpected "magical" behavior that confuses users, and sometimes package managers. :) It's much better to make this an OPTION which the user can select. (Obligatory discussion about how it would be nice if our OPTIONS were smart enough to pick the right defaults based on the environment suppressed.) Doug On 01/09/2012 06:59, Lars Balker Rasmussen wrote: > lbr 2012-01-09 14:59:32 UTC > > FreeBSD ports repository > > Modified files: > textproc/p5-ack Makefile pkg-plist > Log: > p5-ack comes with a plugin for bash shell completion (shells/bash_completion). This patch installs the plugin if the bash completion system is installed. > > PR: 163517 http://www.FreeBSD.org/cgi/query-pr.cgi?pr=163517 > Submitted by: Adam Weinberger > > Revision Changes Path > 1.32 +14 -1 ports/textproc/p5-ack/Makefile > 1.3 +1 -0 ports/textproc/p5-ack/pkg-plist > > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/textproc/p5-ack/Makefile.diff?&r1=1.31&r2=1.32&f=h > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/textproc/p5-ack/pkg-plist.diff?&r1=1.2&r2=1.3&f=h > -- You can observe a lot just by watching. -- Yogi Berra Breadth of IT experience, and depth of knowledge in the DNS. Yours for the right price. :) http://SupersetSolutions.com/