Date: Mon, 09 Jan 2012 15:01:46 -0800 From: Doug Barton <dougb@FreeBSD.org> To: Lars Balker Rasmussen <lbr@FreeBSD.org> Cc: cvs-ports@FreeBSD.org, adamw@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/textproc/p5-ack Makefile pkg-plist Message-ID: <4F0B71DA.6000707@FreeBSD.org> In-Reply-To: <201201091459.q09ExWNN058008@repoman.freebsd.org> References: <201201091459.q09ExWNN058008@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Please don't add new dependencies based on things that exist, or don't exist in LOCALBASE. This causes unexpected "magical" behavior that confuses users, and sometimes package managers. :) It's much better to make this an OPTION which the user can select. (Obligatory discussion about how it would be nice if our OPTIONS were smart enough to pick the right defaults based on the environment suppressed.) Doug On 01/09/2012 06:59, Lars Balker Rasmussen wrote: > lbr 2012-01-09 14:59:32 UTC > > FreeBSD ports repository > > Modified files: > textproc/p5-ack Makefile pkg-plist > Log: > p5-ack comes with a plugin for bash shell completion (shells/bash_completion). This patch installs the plugin if the bash completion system is installed. > > PR: 163517 http://www.FreeBSD.org/cgi/query-pr.cgi?pr=163517 > Submitted by: Adam Weinberger <adamw@FreeBSD.org> > > Revision Changes Path > 1.32 +14 -1 ports/textproc/p5-ack/Makefile > 1.3 +1 -0 ports/textproc/p5-ack/pkg-plist > > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/textproc/p5-ack/Makefile.diff?&r1=1.31&r2=1.32&f=h > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/textproc/p5-ack/pkg-plist.diff?&r1=1.2&r2=1.3&f=h > -- You can observe a lot just by watching. -- Yogi Berra Breadth of IT experience, and depth of knowledge in the DNS. Yours for the right price. :) http://SupersetSolutions.com/
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4F0B71DA.6000707>