Date: Sat, 11 Oct 2014 23:51:21 +0200 From: Baptiste Daroussin <bapt@FreeBSD.org> To: Chris Rees <crees@physics.org> Cc: Dan Langille <dan@langille.org>, freebsd-ports@freebsd.org Subject: Re: is bsd.database.mk out of sync with Uses/pgsql.mk? Message-ID: <20141011215121.GO19486@ivaldir.etoilebsd.net> In-Reply-To: <46E7BED8-0B81-4AB8-BA60-B3C0402CD00D@physics.org> References: <7E30A7E8-D312-4861-BB25-E2AE6B3F405E@langille.org> <20140928103641.GD40373@ivaldir.etoilebsd.net> <46E7BED8-0B81-4AB8-BA60-B3C0402CD00D@physics.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--i7KxW38SoMauyveo Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Oct 11, 2014 at 08:45:51AM +0100, Chris Rees wrote: >=20 >=20 > On 28 September 2014 11:36:41 BST, Baptiste Daroussin <bapt@FreeBSD.org> = wrote: > >On Sat, Sep 27, 2014 at 03:52:56PM -0400, Dan Langille wrote: > >> Today I encountered these build messages with poudriere: > >>=20 > >> Invalid PGSQL default version 92; valid versions are 8.4 9.0 9.1 9.2 > >9.3 9.4 > >>=20 > >> These messages originate in Mk/Uses/pgsql.mk > >>=20 > >> But Mk/bsd.database.mk claims a different format is correct: > >>=20 > >> # DEFAULT_PGSQL_VER > >> # - PostgreSQL default version, currently 90. > >>=20 > >>=20 > >> Do you agree that the comments in Mk/bsd.database.mk need to updated? > > > >Everything should migrate to USES=3Dpgsql and the code in bsd.database.mk > >should > >just die. > > >=20 > I'm pretty sure I put developer warnings there too about this! >=20 > Chris >=20 Putting warning is ok but you should also driver the migration so far I did most of the migrations. Bapt --i7KxW38SoMauyveo Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEARECAAYFAlQ5plkACgkQ8kTtMUmk6ExaPwCfUtFImJQMvYwXtLP2Y6CLPq+h i+4An0m11zgAW/9rmx4c4FUulw/CP7LP =hbOF -----END PGP SIGNATURE----- --i7KxW38SoMauyveo--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20141011215121.GO19486>