From owner-svn-src-all@FreeBSD.ORG  Fri Jan  6 19:05:16 2012
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id E44651065670;
	Fri,  6 Jan 2012 19:05:16 +0000 (UTC)
	(envelope-from glebius@FreeBSD.org)
Received: from cell.glebius.int.ru (glebius.int.ru [81.19.64.117])
	by mx1.freebsd.org (Postfix) with ESMTP id 63C9F8FC1A;
	Fri,  6 Jan 2012 19:05:16 +0000 (UTC)
Received: from cell.glebius.int.ru (localhost [127.0.0.1])
	by cell.glebius.int.ru (8.14.5/8.14.5) with ESMTP id q06J5FAN064919;
	Fri, 6 Jan 2012 23:05:15 +0400 (MSK)
	(envelope-from glebius@FreeBSD.org)
Received: (from glebius@localhost)
	by cell.glebius.int.ru (8.14.5/8.14.5/Submit) id q06J5FAc064918;
	Fri, 6 Jan 2012 23:05:15 +0400 (MSK)
	(envelope-from glebius@FreeBSD.org)
X-Authentication-Warning: cell.glebius.int.ru: glebius set sender to
	glebius@FreeBSD.org using -f
Date: Fri, 6 Jan 2012 23:05:15 +0400
From: Gleb Smirnoff <glebius@FreeBSD.org>
To: Navdeep Parhar <np@FreeBSD.org>
Message-ID: <20120106190515.GU34721@FreeBSD.org>
References: <201201061829.q06ITfP0001841@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=koi8-r
Content-Disposition: inline
In-Reply-To: <201201061829.q06ITfP0001841@svn.freebsd.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org,
	src-committers@FreeBSD.org
Subject: Re: svn commit: r229714 - head/sys/netinet
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 06 Jan 2012 19:05:17 -0000

  Navdeep,

On Fri, Jan 06, 2012 at 06:29:41PM +0000, Navdeep Parhar wrote:
N> Author: np
N> Date: Fri Jan  6 18:29:40 2012
N> New Revision: 229714
N> URL: http://svn.freebsd.org/changeset/base/229714
N> 
N> Log:
N>   Always release the inp lock before returning from tcp_detach.
				 ^ after ?

N> Modified:
N>   head/sys/netinet/tcp_usrreq.c
N> 
N> Modified: head/sys/netinet/tcp_usrreq.c
N> ==============================================================================
N> --- head/sys/netinet/tcp_usrreq.c	Fri Jan  6 18:18:25 2012	(r229713)
N> +++ head/sys/netinet/tcp_usrreq.c	Fri Jan  6 18:29:40 2012	(r229714)
N> @@ -204,8 +204,10 @@ tcp_detach(struct socket *so, struct inp
N>  			tcp_discardcb(tp);
N>  			in_pcbdetach(inp);
N>  			in_pcbfree(inp);
N> -		} else
N> +		} else {
N>  			in_pcbdetach(inp);
N> +			INP_WUNLOCK(inp);
N> +		}
N>  	}
N>  }
N>  

-- 
Totus tuus, Glebius.