From owner-svn-src-head@FreeBSD.ORG Sun Mar 17 09:33:48 2013 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 62A82E2F; Sun, 17 Mar 2013 09:33:48 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: from cell.glebius.int.ru (glebius.int.ru [81.19.69.10]) by mx1.freebsd.org (Postfix) with ESMTP id C94D893B; Sun, 17 Mar 2013 09:33:47 +0000 (UTC) Received: from cell.glebius.int.ru (localhost [127.0.0.1]) by cell.glebius.int.ru (8.14.6/8.14.6) with ESMTP id r2H9XdDr062104; Sun, 17 Mar 2013 13:33:39 +0400 (MSK) (envelope-from glebius@FreeBSD.org) Received: (from glebius@localhost) by cell.glebius.int.ru (8.14.6/8.14.6/Submit) id r2H9XdKu062103; Sun, 17 Mar 2013 13:33:39 +0400 (MSK) (envelope-from glebius@FreeBSD.org) X-Authentication-Warning: cell.glebius.int.ru: glebius set sender to glebius@FreeBSD.org using -f Date: Sun, 17 Mar 2013 13:33:39 +0400 From: Gleb Smirnoff To: Andre Oppermann Subject: Re: svn commit: r248417 - head/sys/sys Message-ID: <20130317093339.GT48089@FreeBSD.org> References: <201303170739.r2H7djP1098888@svn.freebsd.org> <51458691.4090107@freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline In-Reply-To: <51458691.4090107@freebsd.org> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 17 Mar 2013 09:33:48 -0000 On Sun, Mar 17, 2013 at 10:02:09AM +0100, Andre Oppermann wrote: A> On 17.03.2013 08:39, Gleb Smirnoff wrote: A> > Author: glebius A> > Date: Sun Mar 17 07:39:45 2013 A> > New Revision: 248417 A> > URL: http://svnweb.freebsd.org/changeset/base/248417 A> > A> > Log: A> > Add MEXT_ALIGN() macro, similar to M_ALIGN() and MH_ALIGN(), but for A> > mbufs with external buffer. A> A> While you are cleaning up the mbuf usage wouldn't it make sense to remove A> these macros, instead of adding new ones, and use m_align() which handles A> all these cases internally? I'm thinking about this. Maybe it is worth to request tail alignment as a flag to the allocating function itself? -- Totus tuus, Glebius.