From owner-p4-projects@FreeBSD.ORG  Tue Jul 18 16:23:36 2006
Return-Path: <owner-p4-projects@FreeBSD.ORG>
X-Original-To: p4-projects@freebsd.org
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 8A88716A4E2; Tue, 18 Jul 2006 16:23:36 +0000 (UTC)
X-Original-To: perforce@freebsd.org
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 65EAE16A4DE;
	Tue, 18 Jul 2006 16:23:36 +0000 (UTC)
	(envelope-from scottl@samsco.org)
Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57])
	by mx1.FreeBSD.org (Postfix) with ESMTP id D537D43D72;
	Tue, 18 Jul 2006 16:23:35 +0000 (GMT)
	(envelope-from scottl@samsco.org)
Received: from [10.10.3.185] ([165.236.175.187]) (authenticated bits=0)
	by pooker.samsco.org (8.13.4/8.13.4) with ESMTP id k6IGNScE002194;
	Tue, 18 Jul 2006 10:23:34 -0600 (MDT)
	(envelope-from scottl@samsco.org)
Message-ID: <44BD0AF7.8030408@samsco.org>
Date: Tue, 18 Jul 2006 10:23:19 -0600
From: Scott Long <scottl@samsco.org>
User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.7.12) Gecko/20060206
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Paolo Pisati <piso@freebsd.org>
References: <200607181107.k6IB7Vf1040641@repoman.freebsd.org>
In-Reply-To: <200607181107.k6IB7Vf1040641@repoman.freebsd.org>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=0.0 required=3.8 tests=none autolearn=failed 
	version=3.1.1
X-Spam-Checker-Version: SpamAssassin 3.1.1 (2006-03-10) on pooker.samsco.org
Cc: Perforce Change Reviews <perforce@freebsd.org>
Subject: Re: PERFORCE change 101845 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 18 Jul 2006 16:23:36 -0000

Paolo Pisati wrote:
> http://perforce.freebsd.org/chv.cgi?CH=101845
> 
> Change 101845 by piso@piso_newluxor on 2006/07/18 11:07:29
> 
> 	Defining an interrupt handler as INTR_FAST means 
> 	the interrupt thread associated to this interrupt event
> 	won't be created: actually with filter+ithread, we need
> 	that thread. 
> 
> Affected files ...
> 
> .. //depot/projects/soc2006/intr_filter/dev/em/if_em.c#7 edit
> 
> Differences ...
> 
> ==== //depot/projects/soc2006/intr_filter/dev/em/if_em.c#7 (text+ko) ====
> 
> @@ -1986,7 +1986,7 @@
>  	 */
>  	TASK_INIT(&sc->link_task, 0, em_handle_link, sc);
>  	if ((error = bus_setup_intr(dev, sc->res_interrupt,
> -	    INTR_TYPE_NET | INTR_FAST, em_intr_fast, em_handle_rxtx, sc,
> +	    INTR_TYPE_NET, em_intr_fast, em_handle_rxtx, sc,
>  	    &sc->int_handler_tag)) != 0) {
>  		device_printf(dev, "Failed to register fast interrupt "
>  			    "handler: %d\n", error);

Now you've made if_em no longer be MPSAFE.

Scott