Date: Mon, 3 Dec 2018 20:20:34 +0200 From: Konstantin Belousov <kostikbel@gmail.com> To: Sevan Janiyan <sevan@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r341435 - head/bin/pkill Message-ID: <20181203182034.GH2378@kib.kiev.ua> In-Reply-To: <201812031800.wB3I0kJN013997@repo.freebsd.org> References: <201812031800.wB3I0kJN013997@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Dec 03, 2018 at 06:00:46PM +0000, Sevan Janiyan wrote: > Author: sevan (doc committer) > Date: Mon Dec 3 18:00:46 2018 > New Revision: 341435 > URL: https://svnweb.freebsd.org/changeset/base/341435 > > Log: > Note these tools use kvm(3) and not procfs as in Solaris. > > Obtained from: NetBSD > MFC after: 7 days > > Modified: > head/bin/pkill/pkill.1 > > Modified: head/bin/pkill/pkill.1 > ============================================================================== > --- head/bin/pkill/pkill.1 Mon Dec 3 17:51:22 2018 (r341434) > +++ head/bin/pkill/pkill.1 Mon Dec 3 18:00:46 2018 (r341435) > @@ -29,7 +29,7 @@ > .\" ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE > .\" POSSIBILITY OF SUCH DAMAGE. > .\" > -.Dd December 1, 2018 > +.Dd December 3, 2018 > .Dt PKILL 1 > .Os > .Sh NAME > @@ -241,6 +241,11 @@ or > .Nm pkill > process will never consider itself nor system processes (kernel threads) as > a potential match. > +.Sh IMPLEMENTATION NOTES > +The Sun Solaris implementation utilised procfs to obtain process information. > +This implementation utilises > +.Xr kvm 3 > +instead. I believe this changes, although formally correct, makes invalid impression. kvm(3) internally uses kern.proc MIB to retrieve information about running processes, we do not scavenge /dev/kmem to obtain the list of processes on the live system. An additional sentence stating that, so no thought about access to kmem appear, would improve it.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20181203182034.GH2378>