From owner-svn-src-projects@freebsd.org Sat Mar 2 20:53:49 2019 Return-Path: Delivered-To: svn-src-projects@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B3929150EBC5 for ; Sat, 2 Mar 2019 20:53:49 +0000 (UTC) (envelope-from asomers@gmail.com) Received: from mail-lf1-x136.google.com (mail-lf1-x136.google.com [IPv6:2a00:1450:4864:20::136]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 2E28D82A82; Sat, 2 Mar 2019 20:53:48 +0000 (UTC) (envelope-from asomers@gmail.com) Received: by mail-lf1-x136.google.com with SMTP id x206so871068lff.3; Sat, 02 Mar 2019 12:53:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=9+q4ubd7HId9zlWaVzomEbN1s2OGfPEfogedFT0Bw6Y=; b=ilK90jfZeA5+qdQdRWVvWPyhSz42oAXbdqEGRFe3fnJF45nPCvJ/eVPdOiQPnGJPmH vPIIOzsrnKQFM7wgybII0/0+Qgyh7OYDJy2ZvB7qE0liTZmq+4ACjEt1a4+s1H8JNyX4 H8osQxJkzaZGs9MAyrNSJWOcmm9YAWXvDzS28TGpE22riXqswmTc3ZbU+UDRZimc/RLm 9lJv8smwICowKhr89L2OqnPOQh/Q4ID5ShUUkoBaEPLV2KYBfdEZZAfoAY12HmevqliL UcrGTEj3ziuunLivNCE3wxg1PS8UKPi85gifTseKQpda9GE3bRdpH2XT9TYtRjL01TYI dcrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=9+q4ubd7HId9zlWaVzomEbN1s2OGfPEfogedFT0Bw6Y=; b=TgbHtB7lGZxLLefXYCB/UKeu4TocWFFaM7syNu43jtK+oJuXlDYgj/lCzuDX2TigoG riJhT+a9b13//WKS5vCmCGGC+yScyqyHzc0KZ8i9cU73QJohSGwnmfjBJ65EaLOdIqT3 vMKV5t+kIG1TtGMiV9MtYjqj45ydvKtYbhXpSUcc2HEP3vrOV77oVvzIFDLk1rqyoMVh 4P/IIE4oiNPz6Fz7Hc+wVLvdQ8n/sy4Ajeq2K+VZCtBMcr81J1i80dIARX6blilafLUL YotVgS1Fmb+JQnXkZjoMQmSGVDEVWP05VnrjOzO2SouUhjtoJODW0lJUV+ud6NuZ6PoR tCrQ== X-Gm-Message-State: APjAAAV1Vq1bAtQAf/Wf8BbcfDGRvSOS50TdvZK5K+f+haaBFcIigHYc nfTf20Uy8219ckLYjnV9q4yhp4DQKpHRxwbfVy4= X-Google-Smtp-Source: APXvYqz8Ofpzw99krPl7AydoYmgyzXWWBmdQqLnDtpY0otJUOEVpL9T5+jOLvX2r2vX3bFWWCpRpHKCGQRSIpXIu+us= X-Received: by 2002:ac2:415a:: with SMTP id c26mr6806963lfi.62.1551560026370; Sat, 02 Mar 2019 12:53:46 -0800 (PST) MIME-Version: 1.0 References: <201903021628.x22GSTTV073206@repo.freebsd.org> <2E0BAFA6-3DEC-4749-9042-E70A39C90CE3@gmail.com> In-Reply-To: <2E0BAFA6-3DEC-4749-9042-E70A39C90CE3@gmail.com> From: alan somers Date: Sat, 2 Mar 2019 13:53:34 -0700 Message-ID: Subject: Re: svn commit: r344727 - projects/fuse2/tests/sys/fs/fuse To: Enji Cooper Cc: Alan Somers , src-committers , svn-src-projects@freebsd.org X-Rspamd-Queue-Id: 2E28D82A82 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=ilK90jfZ; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of asomers@gmail.com designates 2a00:1450:4864:20::136 as permitted sender) smtp.mailfrom=asomers@gmail.com X-Spamd-Result: default: False [-6.07 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; FREEMAIL_FROM(0.00)[gmail.com]; R_SPF_ALLOW(-0.20)[+ip6:2a00:1450:4000::/36]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; RCVD_TLS_LAST(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; TO_DN_SOME(0.00)[]; NEURAL_HAM_SHORT(-0.24)[-0.244,0]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; RCVD_IN_DNSWL_NONE(0.00)[6.3.1.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.5.4.1.0.0.a.2.list.dnswl.org : 127.0.5.0]; MX_GOOD(-0.01)[cached: alt3.gmail-smtp-in.l.google.com]; IP_SCORE(-2.82)[ip: (-9.68), ipnet: 2a00:1450::/32(-2.29), asn: 15169(-2.04), country: US(-0.07)]; FREEMAIL_TO(0.00)[gmail.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+,1:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US]; RCVD_COUNT_TWO(0.00)[2]; DWL_DNSWL_NONE(0.00)[gmail.com.dwl.dnswl.org : 127.0.5.0] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-projects@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the src " projects" tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 02 Mar 2019 20:53:49 -0000 On Sat, Mar 2, 2019, 1:38 PM Enji Cooper (yaneurabeya) < yaneurabeya@gmail.com wrote: > > > > On Mar 2, 2019, at 12:31, Enji Cooper (yaneurabeya) < > yaneurabeya@gmail.com> wrote: > > > > > >> On Mar 2, 2019, at 11:38, Enji Cooper (yaneurabeya) < > yaneurabeya@gmail.com> wrote: > >> > >> > >>> On Mar 2, 2019, at 08:28, Alan Somers wrote: > > > > =E2=80=A6 > > > >>> Oddly, it's not possible to skip a test in any other way. > > > > I want to highlight this sentence a bit. > > > > It=E2=80=99s possible to skip test cases by prefixing them with `DISABL= ED_` =E2=80=94 > which you can then ignore when rerunning the test program via > `=E2=80=94gtest_also_run_disabled_tests`. However, you can actually skip = tests at > > One nit in my prior explanation that I need to correct... > > It=E2=80=99s possible to skip test cases -> It=E2=80=99s possible to igno= re test cases > > =E2=80=A6 since `DISABLED_` is more about filtering than skipping. > > Cheers, > -Enji Yeah, it's different. And the problem with SKIP is that it isn't in any released version of GoogleTest yet.