From nobody Tue Apr 28 19:21:40 2026 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4g4r064q4Nz6byWR; Tue, 28 Apr 2026 19:21:42 +0000 (UTC) (envelope-from diizzy@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R12" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4g4r063rWZz4539; Tue, 28 Apr 2026 19:21:42 +0000 (UTC) (envelope-from diizzy@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1777404102; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sHhQkAsMj7JlugbTlkWxtsdON3ReBsF1WflzbjB0o94=; b=GrDZwV3wIYzNSoKJMhO2HGEP/7kUEykkN5/Smn0qY5l98KC0Dvhn9FBVUxocjpAYzfG9CV TAfXfsHv7li7LwyH0MLtGhstbI5T2Trw6GiCVkhkIiotDjW4+0QktM8M8tL/o6shxKt/BP +WuAIsGx7RuvL9lMsI2FS0DeqF05WtWqyE/u3EBwAA4vXQt/009oSp2b0r5r/HNbI975iv Oxaeyt/Li3UkdzNq2IiEEHJmDDHyz5oXICUrT0NOrGxuPOmesdcZEhdjS+a0ckqNR/a12P OPt55aO2Af+ww2ELgXzJrMbqcy9jle7yqrZ/poFo1IONzAaI/cnHFpJrxaHr1Q== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1777404102; a=rsa-sha256; cv=none; b=NHyPxUY7g9i6NOtCDYcnwiVB3zuNijenYcelo3HKPoLSB3XcGT9X+F4Y+NQAdkzcpsruvW 5LGorhsJpoJV0s1V9R1gNJvaZW3MfQ69mE42jcv5Udxi+JTm1Tfku4gC8tRiXLOdaogOYm ZlP0wQQFiyaqmJTI9yp0DWlFVaeqGxmWzgaeMI2mLnyUFnQwOBXpSl/ZoX/mhZEKhTMA9Z gEM6yNZTwsQEA0PJGHA12DOMkdn8fjYtksHKMGFWAX4deFEqe6fHQDV/EH6B3L6mSpSScA jwSMAlephGv6Cj7SuSZfBiTtN+XVg8ULd2z7vUcJJdcQr9HkDeILwfzxgkR+rA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1777404102; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sHhQkAsMj7JlugbTlkWxtsdON3ReBsF1WflzbjB0o94=; b=SDmZqyKmMEukTSA2Amujm0Nn4vXFUMZT4zShvqlCgQbdmhqyro6BstWJgxIqq+tZ9Mngbh eeVItimMia7ZLU2pvg+3jpRj2AZIPOl/Qi6NX8Deu9oryeve4ImFRHQDH3NxfJUbRNUS9E pSeDfvI+p+LL/s5u0pRQhzO2RsqHZJV6qjvsTWXG+al1RNZ9252cwMQbvcrWCjE2i9wXju lsVBopRkxkJcYxsheebAq0GeDQR+Cmbc0NrcnFyJqh3fTQX6X4u8P1q191EuVGGInoqv9+ mM3RkyNA4zg0NRltnZ7Ws4tZaKHx25aSXJiSwTE5ah2g+dsqe6y1Bz4Lgeidpw== Received: from [192.168.1.231] (217-209-194-237-no600.tbcn.telia.com [217.209.194.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: diizzy/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4g4r056Wt8zkXd; Tue, 28 Apr 2026 19:21:41 +0000 (UTC) (envelope-from diizzy@FreeBSD.org) Message-ID: <66ff8588-89bb-49ec-a208-7a7d3e2e42b7@FreeBSD.org> Date: Tue, 28 Apr 2026 21:21:40 +0200 List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-ports-main@freebsd.org Sender: owner-dev-commits-ports-main@FreeBSD.org MIME-Version: 1.0 User-Agent: Betterbird (Windows) Subject: Re: git: 70718cbf1b00 - main - Mk/Uses/meson.mk: Silence warning during do-configure stage To: Gleb Popov Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org References: <69f0fbce.202f4.25de3156@gitrepo.freebsd.org> Content-Language: en-US From: Daniel Engberg In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 2026-04-28 20:50, Gleb Popov wrote: > On Tue, Apr 28, 2026 at 9:26 PM Daniel Engberg wrote: >> >> PR: 294808 >> Reviewed by: desktop (arrowd), previous interation > > desktop@ did not give you approval on this iteration, nor approved > bf193dc1da282c769d3291817a8378adbd762ac7 and you didn't wait even 3 > days to give me a chance to review this. > > But I'm too tired to fight you, so I'm letting portmgr to chime in if > they are interested. Hi, The only difference is that the framework will now throw an error when Meson ports are using CONFIGURE_ARGS for passing actual MESON_ARGS which is incorrect as stated by Porters Handbook and Mk/Uses/meson.mk (and not breaking things). Which is what I assumed (being naive) the first time didn't occur in tree and I managed to cherry pick ports that didn't (to be fair, only a handful out of 1000+ do). https://docs.freebsd.org/en/books/porters-handbook/book/#using-meson https://cgit.freebsd.org/ports/tree/Mk/Uses/meson.mk#n15 Additionally there are no PRs or open reviews on reviews.freebsd.org or other documentation claiming otherwise at least that I can find. Building ~2000+ ports later (in total) I can't find more ports violating this or failing. bf193dc1da282c769d3291817a8378adbd762ac7 falls under blanket https://docs.freebsd.org/en/articles/committers-guide/#ports-qa-misc-blanket-approval In hindsight, I should've built the all meson from the start but that takes a day or so even on a fairly beefy box. Best regards, Daniel