From owner-freebsd-bugs@FreeBSD.ORG  Sun Sep 12 20:10:44 2004
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 53CC216A4D2
	for <freebsd-bugs@hub.freebsd.org>;
	Sun, 12 Sep 2004 20:10:44 +0000 (GMT)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 485FC43D2D
	for <freebsd-bugs@hub.freebsd.org>;
	Sun, 12 Sep 2004 20:10:44 +0000 (GMT)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.12.11/8.12.11) with ESMTP id i8CKAiqs028194
	for <freebsd-bugs@freefall.freebsd.org>; Sun, 12 Sep 2004 20:10:44 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.12.11/8.12.11/Submit) id i8CKAim6028193;
	Sun, 12 Sep 2004 20:10:44 GMT
	(envelope-from gnats)
Date: Sun, 12 Sep 2004 20:10:44 GMT
Message-Id: <200409122010.i8CKAim6028193@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
From: Giorgos Keramidas <keramida@freebsd.org>
Subject: Re: bin/71630: [PATCH] cleanup of the usr.sbin/pppd code
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
Reply-To: Giorgos Keramidas <keramida@freebsd.org>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 12 Sep 2004 20:10:44 -0000

The following reply was made to PR bin/71630; it has been noted by GNATS.

From: Giorgos Keramidas <keramida@freebsd.org>
To: Dan Lukes <dan@obluda.cz>
Cc: bug-followup@freebsd.org
Subject: Re: bin/71630: [PATCH] cleanup of the usr.sbin/pppd code
Date: Sun, 12 Sep 2004 22:42:06 +0300

 On 2004-09-12 04:38, Dan Lukes <dan@obluda.cz> wrote:
 > -     FILE *iffile;
 > +     FILE *iffile = iffile; /* to avoid "may be used unitialized" warning */
 
 Nope.  NULL is the proper initialization value for (FILE *) objects.
 This way any bugs that might exist further down will be exposed by a
 dereference of a NULL pointer which everyone will notice.  Hiding the
 bugs behind an even more bogus initialization is not a good thing.
 
 The rest of this looks fine, IMHO.