Date: Sun, 12 Sep 2004 20:10:44 GMT From: Giorgos Keramidas <keramida@freebsd.org> To: freebsd-bugs@FreeBSD.org Subject: Re: bin/71630: [PATCH] cleanup of the usr.sbin/pppd code Message-ID: <200409122010.i8CKAim6028193@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR bin/71630; it has been noted by GNATS. From: Giorgos Keramidas <keramida@freebsd.org> To: Dan Lukes <dan@obluda.cz> Cc: bug-followup@freebsd.org Subject: Re: bin/71630: [PATCH] cleanup of the usr.sbin/pppd code Date: Sun, 12 Sep 2004 22:42:06 +0300 On 2004-09-12 04:38, Dan Lukes <dan@obluda.cz> wrote: > - FILE *iffile; > + FILE *iffile = iffile; /* to avoid "may be used unitialized" warning */ Nope. NULL is the proper initialization value for (FILE *) objects. This way any bugs that might exist further down will be exposed by a dereference of a NULL pointer which everyone will notice. Hiding the bugs behind an even more bogus initialization is not a good thing. The rest of this looks fine, IMHO.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200409122010.i8CKAim6028193>