From owner-svn-src-head@freebsd.org Tue Apr 4 12:38:02 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3F42BD2D0FD for ; Tue, 4 Apr 2017 12:38:02 +0000 (UTC) (envelope-from mailing-machine@vniz.net) Received: from mail-lf0-f68.google.com (mail-lf0-f68.google.com [209.85.215.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id E8148950 for ; Tue, 4 Apr 2017 12:38:01 +0000 (UTC) (envelope-from mailing-machine@vniz.net) Received: by mail-lf0-f68.google.com with SMTP id v2so15417604lfi.2 for ; Tue, 04 Apr 2017 05:38:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=tMD33QUFqBPjGzXohfPDTvvCw/x8keBKa2QR8O5hPq4=; b=myrgVtCum+yFhyDs3/jUy+fe38K5Z86CiIdo/+ia9KxYtT9kypocUQABuhAwp/SduJ JfEMwwJNAZqJ0c5k1MklYwaLel1UkMwP5zCMKBGDGKBXxRp56vbuclCAzRnjv/425p+L iZjQae3Rc+50utrlIlLS2KthVDDfWOS++nAVcnq/1fDdhsSkoPrfC7KXcUntGmfs2hcp DYPf98el6e01cLmoBtYDHhpjerSLEdbwCAhAdvRu0QxGRWn6fDWDyzoBnmQJdC4myb8+ mVttOPF4AVNrxWhE3h4Xa+66Sikm0DU4KYoyqjB1JD2GSh/3FiyQRyrgR3MTWojaYBQi 25tA== X-Gm-Message-State: AFeK/H1huepb1nc9zbS1Z3V/b1Lmb+j7ovOwZoaQ3HD0+FjwDjs0kALXoIrAaJKIIUqrUQ== X-Received: by 10.46.20.87 with SMTP id 23mr6435014lju.54.1491309474117; Tue, 04 Apr 2017 05:37:54 -0700 (PDT) Received: from [192.168.1.2] ([89.169.173.68]) by smtp.gmail.com with ESMTPSA id w78sm3134953lfi.23.2017.04.04.05.37.53 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 04 Apr 2017 05:37:53 -0700 (PDT) Subject: Re: svn commit: r316477 - head/usr.bin/grep To: Kyle Evans References: <201704032316.v33NGpbo037305@repo.freebsd.org> <4ceb1a18-3a72-c0e3-b2e2-f71d687cd153@freebsd.org> Cc: Ed Maste , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org From: Andrey Chernov Message-ID: <9018c8db-2a89-c8b2-750b-fe11ac08333f@freebsd.org> Date: Tue, 4 Apr 2017 15:37:52 +0300 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Apr 2017 12:38:02 -0000 On 04.04.2017 15:24, Kyle Evans wrote: > On Tue, Apr 4, 2017 at 7:07 AM, Andrey Chernov > wrote: > > On 04.04.2017 2:16, Ed Maste wrote: > > if (color) > > - fprintf(stdout, "\33[m\33[K"); > > + fprintf(stdout, "\33[00m\33[K"); > > Please back that one out. We don't need to handle internally or print > remotely excessive 00. > At least according to > https://en.wikipedia.org/wiki/ANSI_escape_code > > "With no parameters, CSI m is treated as CSI 0 m (reset / normal), which > is typical of most of the ANSI escape sequences." > > > Hi ache@, > > This specific change was made in the name of explicitly matching colored > output of GNU grep for simplification of regression test purposes, > rather than for good form. Is it still unacceptable to do so? IMHO everyday usage by everyone weights much more than occasional regression tests run which can be fixed instead of this place. F.e. we already do a lot of local fixes in the NetBSD regression tests instead of pretending to mimic NetBSD in 100% in the system itself.